[FIX] l10n_do: Add account groups & correct tax names for N07-2018 #27172
Conversation
|
Hi @qdp-odoo. We did this changes in the Odoo Hackaton held in DR. The local community would like to have this changes merge as soon as you guys can have a look at it, as we'll also be changing a few things in master before it hits 12.0 Thanks in advance. |
|
cc: @oco-odoo |
gustavovalverde
changed the title
There was a problem hiding this comment.
it crashes at the installation... Dude, have you ever tested your changes??
raise ValueError('External ID not found in the system: %s' % xmlid)
odoo.tools.convert.ParseError: "External ID not found in the system: l10n_do.account_group_62" while parsing /home/qdp/dev/odoo/addons/l10n_do/data/account_group.xml:430, near <record id="account_group_6104" model="account.group">
<field name="parent_id" ref="l10n_do.account_group_62"/>
<field name="name">Gastos por Depreciación</field>
<field name="code_prefix">6104</field>
</record>
|
@qdp-odoo I must agree that I trusted Robodoo. I'll tesst on Odoo.sh ASAP |
|
@qdp-odoo fixed and humanly tested:
|
|
@qdp-odoo Just a kind reminder |
robodoo
added
CI 🤖
|
@qdp-odoo this is more than ready to be merged. Already using it on production with no issues so far (except that last commit) |
|
Is it possible to squash in a single commit? For example: 2dcdfe108bc0436828fa3ce84e67af77de7821e0 This one could be squashed |
|
Is it that (a) you want to squash the whole PR? If that's what you need, no problem. Or (b) you want me to squash it from 7f6fc1b to 2dcdfe1; and bc095b1 with 064dace? |
|
@gustavovalverde We can squash the whole PR if it is good for you |
|
Yeah, no problem at all. |
1. Update tax Groups with N07-2018 Restrict Tax groups just to the 5 available in Norma 07-2018: * ITBIS * ISR * ISC * Propina * Otros Impuestos 2. Do not use 'none' to hide taxes This affect taxes reports, as those reports evaluate the type_tax_use field 3. Rename Taxes and Description for N07-2018 4. Change group taxes name and missing childrens 5. Add account groups to template and CoA 6. Add various missing data opw-1912626
1. Update tax Groups with N07-2018 Restrict Tax groups just to the 5 available in Norma 07-2018: * ITBIS * ISR * ISC * Propina * Otros Impuestos 2. Do not use 'none' to hide taxes This affect taxes reports, as those reports evaluate the type_tax_use field 3. Rename Taxes and Description for N07-2018 4. Change group taxes name and missing childrens 5. Add account groups to template and CoA 6. Add various missing data opw-1912626 closes #27172
|
Merged, thanks! |
Description of the issue/feature this PR addresses:
Current behavior before PR:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr