Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REM] packaging: drop PyYAML dependency #27563

Closed
wants to merge 1 commit into from
Closed

[REM] packaging: drop PyYAML dependency #27563

wants to merge 1 commit into from

Conversation

Elkasitu
Copy link
Contributor

@Elkasitu Elkasitu commented Oct 9, 2018

Commit cf853a7 removed all yml tests
and the yml import engine from Odoo forever, however PyYAML remains a
dependency even though it's not used anymore.

This commit removes any reference to this lib that could be found.

@Elkasitu Elkasitu requested a review from d-fence October 9, 2018 09:08
@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Oct 9, 2018
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 9, 2018
[REM] packaging: drop PyYAML dependency
3de7cde 
Commit cf853a7 removed all yml tests
and the yml import engine from Odoo forever, however PyYAML remains a
dependency even though it's not used anymore.

This commit removes any reference to this lib that could be found.
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Oct 9, 2018
@Elkasitu Elkasitu requested a review from mart-e October 9, 2018 13:01
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Oct 9, 2018
d-fence
d-fence approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@d-fence d-fence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-fence
Copy link
Contributor

d-fence commented Oct 9, 2018

robodoo r+ please

@robodoo robodoo added the r+ 👌 label Oct 9, 2018
robodoo pushed a commit that referenced this pull request Oct 9, 2018
[REM] packaging: drop PyYAML dependency
a277bfb 
Commit cf853a7 removed all yml tests
and the yml import engine from Odoo forever, however PyYAML remains a
dependency even though it's not used anymore.

This commit removes any reference to this lib that could be found.

closes #27563
@robodoo
Copy link
Contributor

robodoo commented Oct 9, 2018

Merged in 9f209dd

@robodoo robodoo closed this Oct 9, 2018
@fw-bot fw-bot deleted the 12.0-de-yaml-ify-adt branch October 20, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-fence d-fence d-fence approved these changes

@mart-e mart-e mart-e approved these changes

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Elkasitu @d-fence @robodoo @mart-e @C3POdoo