[FIX] base: do not crash if rtlcss.cmd is not found #27926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fence
reviewed
Oct 18, 2018
| rtlcss = misc.find_in_path('rtlcss.cmd') | ||
| try: | ||
| rtlcss = misc.find_in_path('rtlcss.cmd') | ||
| except IOError: |
There was a problem hiding this comment.
Shouldn't we put a warning to give an hint to the user ?
There was a problem hiding this comment.
It will still actually display the warning 'You need https://rtlcss.com/ to convert...'
d-fence
approved these changes
Oct 18, 2018
|
robodoo r+ |
|
Merged, thanks! |
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes #27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Sep 23, 2023
Changes in default can be bothersome, embed a full baseline configuration for reliability. closes odoo/odoo#27926 Signed-off-by: Pierre Masereel <pim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr