Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] survey: fix sent_survey domain #28010

Closed

Conversation

d-fence
Copy link
Contributor

@d-fence d-fence commented Oct 22, 2018

survey.user_input type was renamed to input_type in 35a5db9.
This domain was forgotten and made the click_everywhere test fail.

Description of the issue/feature this PR addresses: Fix survey

Current behavior before PR: click on survey menu an appreciate the traceback

Desired behavior after PR is merged: click on survey menu and enjoy a nice app

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

survey.user_input type was renamed to input_type in 35a5db9.
This domain was forgotten and made the click_everywhere test fail.
@d-fence d-fence force-pushed the master-fix-survey-input-type-moc branch from af0cea7 to 5742002 Compare October 22, 2018 12:54
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 22, 2018
@d-fence
Copy link
Contributor Author

d-fence commented Oct 23, 2018

robodoo r+

robodoo pushed a commit that referenced this pull request Oct 23, 2018
survey.user_input type was renamed to input_type in 35a5db9.
This domain was forgotten and made the click_everywhere test fail.

closes #28010
@robodoo
Copy link
Contributor

robodoo commented Oct 23, 2018

Staging failed: ci/runbot on b6f4105c774009e28108cce6f3519370ba0a5e76 (view more at http://runbot.odoo.com/runbot/build/388114)

@robodoo robodoo added error 🙅 and removed merging 👷 CI 🤖 Robodoo has seen passing statuses labels Oct 23, 2018
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 23, 2018
@xmo-odoo
Copy link
Collaborator

robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Oct 23, 2018
@robodoo
Copy link
Contributor

robodoo commented Oct 23, 2018

Merged, thanks!

@robodoo robodoo closed this Oct 23, 2018
@fw-bot fw-bot deleted the master-fix-survey-input-type-moc branch October 20, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants