[FIX]hr_holidays: set correct days when creating new leave request #28661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- here, there is need to call '_onchange_leave_dates' method because this method computes number of days according to date_from and date_to fields which are set in method '_onchange_request_parameters'. - so, call '_onchange_leave_dates' after setting date_from and date_to parameters. Related to Issue: 1895291
mart-e
added
OE
This comment has been minimized.
This comment has been minimized.
|
@pka-odoo knowing that 12 is no longer updated, is this PR still needed? |
Not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue: 1895291
Description of the issue/feature this PR addresses:
When trying to create leaves(from a calendar) the first time it shows the wrong duration but click on a half day and unclick, it shows 1 day. in duration.
Current behavior before PR:
When trying to create leaves(from a calendar) the first time it shows the wrong duration but click on a half day and unclick, it shows 1 day. in duration.
Desired behavior after PR is merged:
It shows the correct duration while creating leave request from a calendar.
Issue:
https://www.odoo.com/web#id=1895291&action=327&model=project.task&view_type=form&menu_id=4720
Pad:
https://pad.odoo.com/p/r.79862f847d6b2334a59838d759dd152d
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr