Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] hr_payroll: Add tests for benefits #29304

Closed
wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Contributor

@LucasLefevre LucasLefevre commented Dec 6, 2018

Some use cases are not tested.

Add a test for validating a multiple day benefit: it should be split by day

Add tests for payslip generation based on benefits: it should generate corresponding work_days_lines

  • test with benefit of type leave
  • test with benefit non leave

Task #1915694

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Some behaviors were not tested.
Add 2 tests for payslip generation with additional benefits (type leave or not)
It checks that corresponding worked_day_lines are created in the payslip.

Add a test for validating a multiple day benefit: it should be split by day.
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 6, 2018
@C3POdoo C3POdoo added the RD research & development, internal work label Dec 6, 2018
@tivisse
Copy link
Contributor

tivisse commented Dec 6, 2018

@robodoo r+

@robodoo robodoo added the r+ 👌 label Dec 6, 2018
robodoo pushed a commit that referenced this pull request Dec 6, 2018
Some behaviors were not tested.
Add 2 tests for payslip generation with additional benefits (type leave or not)
It checks that corresponding worked_day_lines are created in the payslip.

Add a test for validating a multiple day benefit: it should be split by day.

closes #29304
@robodoo
Copy link
Contributor

robodoo commented Dec 6, 2018

Merged, thanks!

@robodoo robodoo closed this Dec 6, 2018
@tivisse tivisse deleted the master-benefit-test-lul branch December 6, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants