[FIX] web: remove extra space in kanban dragging images #29642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While dragging kanban record which have a cover image set, the kanban view creates extra space, which makes it difficult to properly target a position. This is because of a jquery.ui issue for sortable when helper=clone is used. In that case, then jquery.ui sortable will create a clone of current element after hiding it. Note that jquery.ui tries to get height to current dragged element after making it hidden(display: none) and display: none, so the element does not return actual height and hence it gives innerHeight which considers height of the image also and extra space is generated. An alternative solution is to add start event in sortable option and 1) show ui.item 2) get height of the element and 3) hide ui.item, which gives proper height of the current dragged element But removing helper=clone will also fix the issue and is not actually required. Note that some special care had to be done to prevent the click from the drag and drop operation to actually open the record. Related to task: #1865788 Closes: odoo#25734
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 19, 2018
While dragging kanban record which have a cover image set, the kanban view creates extra space, which makes it difficult to properly target a position. This is because of a jquery.ui issue for sortable when helper=clone is used. In that case, then jquery.ui sortable will create a clone of current element after hiding it. Note that jquery.ui tries to get height to current dragged element after making it hidden(display: none) and display: none, so the element does not return actual height and hence it gives innerHeight which considers height of the image also and extra space is generated. An alternative solution is to add start event in sortable option and 1) show ui.item 2) get height of the element and 3) hide ui.item, which gives proper height of the current dragged element But removing helper=clone will also fix the issue and is not actually required. Note that some special care had to be done to prevent the click from the drag and drop operation to actually open the record. Related to task: #1865788 Closes: #25734 closes #29642
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dragging kanban record which have a cover image set, the kanban view
creates extra space, which makes it difficult to properly target a
position.
This is because of a jquery.ui issue for sortable when helper=clone is used.
In that case, then jquery.ui sortable will create a clone of current element
after hiding it. Note that jquery.ui tries to get height to current dragged
element after making it hidden(display: none) and display: none, so the element
does not return actual height and hence it gives innerHeight which considers
height of the image also and extra space is generated.
An alternative solution is to add start event in sortable option and
But removing helper=clone will also fix the issue and is not actually required.
Note that some special care had to be done to prevent the click from the
drag and drop operation to actually open the record.
Related to task: #1865788
Closes: #25734
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr