[IMP] snailmail: Failed letters usability #29685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuhn
requested changes
Dec 20, 2018
| @@ -82,7 +82,7 @@ def test_write_mail_with_tracking(self): | |||
| 'partner_id': self.env.ref('base.res_partner_12').id, | |||
| }) | |||
|
|
|||
| with self.assertQueryCount(__system__=5, demo=5): # test_mail only: 5 - 5 | |||
| with self.assertQueryCount(__system__=6, demo=6): # test_mail only: 5 - 5 | |||
There was a problem hiding this comment.
check with @Xavier-Do or @tde-banana-odoo for changes of query counts
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
2b52a70
to
63ac6da
Compare
robodoo
added
CI 🤖
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
63ac6da
to
b64ac12
Compare
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
b64ac12
to
694286a
Compare
pimodoo
reviewed
Dec 26, 2018
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
694286a
to
3e07ba6
Compare
robodoo
added
CI 🤖
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
1bf2b0c
to
1b98afc
Compare
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
1b98afc
to
f728bb7
Compare
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
f728bb7
to
2a3ffc7
Compare
robodoo
added
CI 🤖
pimodoo
reviewed
Dec 28, 2018
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
2a3ffc7
to
65c8ae2
Compare
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
ac6884d
to
448b5aa
Compare
robodoo
added
CI 🤖
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
448b5aa
to
9f3ada3
Compare
aprieels
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
9f3ada3
to
2f72994
Compare
|
@Xavier-Do Is it ok for you now? |
Xavier-Do
reviewed
Jan 17, 2019
| 'model': letter.model, | ||
| 'last_message_date': letter.message_id.date, | ||
| 'module_icon': '/snailmail/static/img/snailmail_failure.png', | ||
| 'snailmail_status': letter.message_id.snailmail_status, |
There was a problem hiding this comment.
snailmail_error on message should be letter.state == 'error' no?
same for status
There was a problem hiding this comment.
do you also want that we use letter.error_code if letter.state == 'error' for snailmail_status?
There was a problem hiding this comment.
If it works as expect yes.
pimodoo
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
2f72994
to
6d6ad09
Compare
robodoo
added
CI 🤖
pimodoo
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
bf80506
to
63ca7d6
Compare
robodoo
added
CI 🤖
When a letter is sent through snailmail and encounter an error, it used
to create an activity to the user to notify him that there was an error
with its letter.
When a user had this activity, he didn't have any clues of what was the
error and how to manage it. So we decided to better handle snailmail
errors and give the possibility to the user to easily fix the source of
the snailmail errors.
First to give a better feedback on the letters in errors, we've made
features similar to ones existing for emails:
- We add a mail message on the document that sent the letter, and put a
small paper plane icon, which is red when an error occurs (like the
envelope for email)
- As letters can be sent in batch, we've also added an entry in the
systray to easily manage the different documents having snailmail
errors like for emails.
Then we identified, the most common errors encountered with the
snailmail letters and give proper way to let the user fix them:
- Missing Required Field:
- The address is not complete, some of the fields are empty.
- We open a wizard allowing the user to modify the partner address
and we try to resend all letters having this error on the modified
partner.
- We also try to avoid this error, by opening the wizard before
sending the letter, but it only works for single documents, not
for batch.
- Trial/Credit Error:
- The user has not enough credits to send letters anymore.
- We open a wizard that give a redirection lnk to add credits on its
iap account.
- No Price Available:
- The destination country is not supported by any of our providers,
and we cannot do anything to send this letter.
- Format Error:
- The format of the pdf report send by the user is refused by our
providers, because some visual stuffs are not respected, for
example blank zone to print barcode or margins.
- We show a wizard to the user letting him check a setting option
that add a cover page in the envelope and the documents will be
send with this extra page containing the address.
- Unknown Error:
- This is not one of the listed error above.
- A wizard suggesting the user to contact support is displayed.
The cron that try to resend letters on error, has been addapted to only
try to send the error of type Trial/No Credit, because the account might
have been reloaded, and other errors, won't change if they have not been
fixed locally.
pimodoo
force-pushed
the
master-snailmail-failed-letters-usability-anp
branch
from
63ca7d6
to
0e1eec3
Compare
pimodoo
approved these changes
Jan 24, 2019
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2019
When a letter is sent through snailmail and encounter an error, it used
to create an activity to the user to notify him that there was an error
with its letter.
When a user had this activity, he didn't have any clues of what was the
error and how to manage it. So we decided to better handle snailmail
errors and give the possibility to the user to easily fix the source of
the snailmail errors.
First to give a better feedback on the letters in errors, we've made
features similar to ones existing for emails:
- We add a mail message on the document that sent the letter, and put a
small paper plane icon, which is red when an error occurs (like the
envelope for email)
- As letters can be sent in batch, we've also added an entry in the
systray to easily manage the different documents having snailmail
errors like for emails.
Then we identified, the most common errors encountered with the
snailmail letters and give proper way to let the user fix them:
- Missing Required Field:
- The address is not complete, some of the fields are empty.
- We open a wizard allowing the user to modify the partner address
and we try to resend all letters having this error on the modified
partner.
- We also try to avoid this error, by opening the wizard before
sending the letter, but it only works for single documents, not
for batch.
- Trial/Credit Error:
- The user has not enough credits to send letters anymore.
- We open a wizard that give a redirection lnk to add credits on its
iap account.
- No Price Available:
- The destination country is not supported by any of our providers,
and we cannot do anything to send this letter.
- Format Error:
- The format of the pdf report send by the user is refused by our
providers, because some visual stuffs are not respected, for
example blank zone to print barcode or margins.
- We show a wizard to the user letting him check a setting option
that add a cover page in the envelope and the documents will be
send with this extra page containing the address.
- Unknown Error:
- This is not one of the listed error above.
- A wizard suggesting the user to contact support is displayed.
The cron that try to resend letters on error, has been addapted to only
try to send the error of type Trial/No Credit, because the account might
have been reloaded, and other errors, won't change if they have not been
fixed locally.
closes #29685
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the behavior of snailmail when errors happen by making something similar to what mail does.
Task #1907998
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr