Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] l10n_nz: Add accounts for new-zealend accounting reports. #29766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] l10n_nz: Add accounts for new-zealend accounting reports. #29766

wants to merge 1 commit into from

Conversation

mja-odoo
Copy link

@mja-odoo mja-odoo commented Dec 27, 2018 •
edited
Loading

Description of the issue/feature this PR addresses:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 27, 2018
@gdgellatly
Copy link
Contributor

@mja-odoo Where is this official document? There isn't one I ever heard of, but even if there was, these changes would definitely not be it. These look very wrong.

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 27, 2018
@gdgellatly
Copy link
Contributor

@mja-odoo Oh I see you've based them off Xero. That is a mistake. Xero is a completely different system. For a start, Xero orders account by type,name. Account code means nothing.

Odoo orders by code and it is pretty standard to order those using a regimented numbering system (as just about everyone else does), e.g. 1 for assets, 2 for liabilities, 3 for equity etc, so unless you are also proposing changing the way odoo orders accounts, then this PR cannot be merged. But even if you were going to change the ordering I don't see the point of messing up a perfectly good numbering system.

By mixing in all different codes and account types you will just make a big mess.

@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 11, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 11, 2019
@hsh-odoo @rgo-odoo
[IMP] l10n_nz: some improvements
e521644 
- kept one tag per grid in tax report
- added menu to show New Zealand specific financial reports

was task# 1915420
was PR odoo#29766
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
@lathama
Copy link
Contributor

lathama commented Apr 15, 2024

@mja-odoo is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mja-odoo @gdgellatly @lathama @C3POdoo @robodoo @hsh-odoo