[FIX] resource, hr_payroll: fix hours_per_day onchange #29951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivisse
force-pushed
the
saas-12.1-resource-fix-hours-lul
branch
3 times, most recently
from
7ab54e2
to
914654c
Compare
|
@robodoo r+ |
In resource, calendar.attendances with a resource_id specified were taken into account to compute the average hours per day. This is incorrect and could lead to hours_per_day being > 24h. Also when hr_payroll is installed, attendance_ids is replaced by normal attendance (those without a resource_id set) in the view. The onchange method was not called to recompute the average hours per day. This commit fixes both issues.
LucasLefevre
force-pushed
the
saas-12.1-resource-fix-hours-lul
branch
from
914654c
to
7791aea
Compare
|
@tivisse r+ |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 10, 2019
In resource, calendar.attendances with a resource_id specified were taken into account to compute the average hours per day. This is incorrect and could lead to hours_per_day being > 24h. Also when hr_payroll is installed, attendance_ids is replaced by normal attendance (those without a resource_id set) in the view. The onchange method was not called to recompute the average hours per day. This commit fixes both issues. closes #29951
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In resource, calendar.attendances with a resource_id specified
were taken into account to compute the average hours per day.
This is incorrect and could lead to hours_per_day being > 24h.
Also when hr_payroll is installed, attendance_ids is replaced
by normal attendance (those without a resource_id set) in the view.
The onchange method was not called to recompute the average hours per day.
This commit fixes both issues.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr