Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payment_razorpay] Razorpay payment gateway for India #30101

Closed

Conversation

sza-odoo
Copy link

Task: https://www.odoo.com/web#id=1904990&action=327&model=project.task&view_type=form&menu_id=4720

Razorpay is a payments solution in India which allows businesses to accept, process and disburse payments.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 10, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 10, 2019
@rop-odoo rop-odoo force-pushed the master-razorpay-payment-integration-sza branch from feb304e to acb6fef Compare January 11, 2019 13:31
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jan 11, 2019
@mba-odoo mba-odoo force-pushed the master-razorpay-payment-integration-sza branch from 8281cc7 to c7ba1d7 Compare January 15, 2019 08:58
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 15, 2019
@mba-odoo mba-odoo force-pushed the master-razorpay-payment-integration-sza branch 2 times, most recently from 1385436 to a636f8b Compare January 15, 2019 09:17
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 15, 2019
Copy link
Contributor

@mart-e mart-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a first review, just a few comments


txs = self.env['payment.transaction'].search([('reference', '=', reference)])
if not txs or len(txs) > 1:
error_msg = 'Razorpay: received data for reference %s' % (reference)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untranslated error message

@api.multi
def _razorpay_form_get_invalid_parameters(self, data):
invalid_parameters = []
if float_compare(float(data.get('amount', '0.0')) / 100, self.amount, precision_digits=2) != 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you no longer need to cast to float in pytyon3, 1/2 gives 0.5 now (and for p2, an easier way is to divide by 100.0)

function display_razorpay_form(provider_form) {
// Open Checkout with further options
var payment_form = $('.o_payment_form');
if(!payment_form.find('i').length)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some missing brackets here? payment_form.attr('disabled','disabled'); is indented as inside this if

@sza-odoo sza-odoo force-pushed the master-razorpay-payment-integration-sza branch from a636f8b to b71cc20 Compare February 8, 2019 07:12
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Feb 8, 2019
@tivisse tivisse closed this Feb 12, 2019
@robodoo robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Feb 12, 2019
kig-odoo and others added 3 commits February 20, 2019 06:32
- add missing docstrings
- correctly order functions
- move functions in correct sections
- follow JS guidelines

closes odoo#31261
Before this commit: select more than two groupbys
in a graph view would have no impact at all if mode
'bar' or 'line' is selected.

This commit allows to correctly handle more than
two groupbys in all modes.

Task ID: 1917948

closes odoo#29673
Payment providers can be used without eCommerce. Therefore, we should be
able to access the payment transactions with only `sale` installed.

opw-1941591

closes odoo#31270
@mart-e
Copy link
Contributor

mart-e commented Feb 20, 2019

reverting ccavenue and reconsidering razorpay instead 🎉

@mart-e mart-e reopened this Feb 20, 2019
@mart-e mart-e force-pushed the master-razorpay-payment-integration-sza branch from b71cc20 to c3025cc Compare February 20, 2019 15:06
Razorpay is a payments solution in India which allows businesses to accept, process and disburse payments.

Related Task ID: 1904990

Co-authored-by: Rohan Patel <rop@odoo.com>
@mart-e mart-e force-pushed the master-razorpay-payment-integration-sza branch from c3025cc to 07712aa Compare February 20, 2019 15:31
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Feb 20, 2019
@AntoineVDV AntoineVDV closed this Sep 1, 2022
@mba-odoo mba-odoo deleted the master-razorpay-payment-integration-sza branch September 2, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants