[web] dashboard view: display imp #30288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
CI 🤖
Polymorphe57
force-pushed
the
12.0-dashboard-view-imp-hbh
branch
from
e60d454
to
88e3c46
Compare
Polymorphe57
force-pushed
the
12.0-dashboard-view-imp-hbh
branch
3 times, most recently
from
aa1a191
to
c01a008
Compare
aab-odoo
reviewed
Feb 21, 2019
| var $svgContainer = $('<div/>', {class: 'o_graph_svg_container'}); | ||
|
|
||
|
|
||
| var $svgContainer = $('<div/>', { class: 'o_graph_svg_container'}); |
| var $svgContainer = $('<div/>', { class: 'o_graph_svg_container'}); | ||
| // Split the tooltip into columns for large data because some portion goes out off the screen. | ||
| if (data.length >= SPLIT_THRESHOLD) { | ||
| $svgContainer.addClass('tooltip_split_in_columns'); |
There was a problem hiding this comment.
prefix all odoo classnames by o_
In graph line mode, min and max abs are displayed beyond the screen when there are less than 3 abs. This is happening because nvd3 fixes their text-anchor to 'middle'. The present commit fixes correctly their text-anchors to start and end respectively by using the '!important' rule (it seems difficult to do otherwise). Co-authored-by: Mohammed Shekha <msh@openerp.com> Related to Task: 1917958
Currently tooltip goes out off the screen when the graph view (in line mode) presents a large number of groups. The present commit splits the tooltip content in three columns when the number of groups exceeds 20. This split is not done in mobile mode because it is not an appropriate in that situation. Co-authored-by: Mohammed Shekha <msh@openerp.com> Related to Task: 1917958
Polymorphe57
force-pushed
the
12.0-dashboard-view-imp-hbh
branch
from
c01a008
to
98dd254
Compare
|
robodoo r+ |
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Task: https://www.odoo.com/web?#id=1917958&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.c823631022033d11e887856d7ca025a3
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr