[FIX] miscellaneous fixes and improvements on Japanese CoA #30780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mart-e could you ask the person responsible for accounting in Japan to check this PR please? Not sure who it is. |
|
@mart-e No need to update translation terms? |
|
@jco-odoo only some chart of accounts as Belgium or Switzerland are in multi-language and where the account translation really matters. For most l10n modules, we don't really care. |
|
@jco-odoo It's been a while. Do you need any info from me to proceed with the merge? |
|
That got out of my sight, but it looks ok. I will check next week together with @nim-odoo |
jco-odoo
added
the
Localization
jco-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 5, 2019
…ounts - Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports closes odoo#30780
|
@nim-odoo It is ok for merging to me. I installed also myself, but maybe in 10.0-fixjp-jco the commit message is a bit better. |
- Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports
nim-odoo
force-pushed
the
10.0-fix-l10n_jp
branch
from
db59536
to
c80a0bd
Compare
robodoo
pushed a commit
that referenced
this pull request
Mar 11, 2019
- Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports closes #30780 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
|
Due to conflicts, I had to ignore changed made into Can you verify and update 11.0 in a new PR? |
|
@KangOl it is probably just the tax group that was added. |
jco-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 14, 2019
…ounts - Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports closes odoo#30780
|
No, it's not just that. Some other fields have also be changed. |
remihb
pushed a commit
to osiell/OCB
that referenced
this pull request
Mar 28, 2019
- Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports closes odoo#30780 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qrtl
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr