[IMP]base: added horizontal scroll for onboarding bars #30823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmrajsinh-jhala
force-pushed
the
master-mobile-improve-onboarding-bars-pka
branch
from
f6c34d5
to
8cef662
Compare
robodoo
added
CI 🤖
|
LGTM |
pka-odoo
force-pushed
the
master-mobile-improve-onboarding-bars-pka
branch
from
8cef662
to
35a5983
Compare
robodoo
added
CI 🤖
pka-odoo
force-pushed
the
master-mobile-improve-onboarding-bars-pka
branch
from
35a5983
to
cc572c5
Compare
pka-odoo
force-pushed
the
master-mobile-improve-onboarding-bars-pka
branch
2 times, most recently
from
ec43a75
to
d7eadbd
Compare
In small devices, onboarding bars are displayed vertial, which takes too much screen space, and user has to scroll down a lot to view actual content. This commit improves the behavior by showing onboarding bars horizontally (with scrolling) in small devices also, and thus occupying minimal screen space. task: 1929048
adr-odoo
force-pushed
the
master-mobile-improve-onboarding-bars-pka
branch
from
d7eadbd
to
4538416
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 22, 2019
In small devices, onboarding bars are displayed vertial, which takes too much screen space, and user has to scroll down a lot to view actual content. This commit improves the behavior by showing onboarding bars horizontally (with scrolling) in small devices also, and thus occupying minimal screen space. task: 1929048 closes #30823
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: 1929048
Description of the issue/feature this PR addresses:
Replace the vertical scroll on the onboarding bars by a horizontal scroll to gain space on small devices
Current behavior before PR:
The design of the onboarding widget on the application like Invoicing or Website is taking a lot of space on mobile.
Desired behavior after PR is merged:
Replace the vertical scroll on the onboarding bars by a horizontal scroll to gain space on small devices
Task:
https://www.odoo.com/web#id=1929048&action=327&model=project.task&view_type=form&menu_id=4720
Pad:
https://pad.odoo.com/p/r.604964ed2b5912583e9d8f63429dec47
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr