[IMP] stock: improvement of putaway usability #30889

svs-odoo · 2019-02-06T13:38:58Z

PutAwayStrategy model was deleted and FixedPutAwayStrategy model was renamed into PutAwayRule.
Now, each location can contain multiple putaway rules, each rule applying either on product or on product category.

The purpose is to:

Add more visibility on putaway settings (with a stat button on product, product category and location views, and a submenu item in Product configuration menu).
Change putaway model to avoid redundancy.

Task #1935169

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

svs-odoo · 2019-02-06T13:41:40Z

@sle-odoo for review please :)

addons/stock/models/product.py

addons/stock/models/product_strategy.py

sle-odoo · 2019-02-06T14:07:25Z

addons/stock/models/product_strategy.py

+    def _compute_product_template_id(self):
+        for record in self:
+            if record.product_id:
+                record.product_tmpl_id = record.product_id.product_tmpl_id


not sure if it is useful

addons/stock/models/stock_location.py

addons/stock/models/product_strategy.py

addons/stock/views/product_strategy_views.xml

addons/stock/views/stock_quant_views.xml

svs-odoo · 2019-02-07T10:55:14Z

All changes are been done @sle-odoo

Yenthe666 · 2019-02-07T11:00:07Z

addons/stock/models/product_strategy.py

+class StockPutawayRule(models.Model):
+    _name = 'stock.putaway.rule'
+    _order = 'sequence,product_id'
+    _description = 'Putaway Rule'


@svs-odoo also needs a _rec_name set as there is no name field on this model?

svs-odoo · 2019-02-18T09:10:19Z

@sle-odoo Commits was squashed. Must wait for runbot, but it was green before to squash, so I think it's OK !

sle-odoo · 2019-02-18T10:54:05Z

addons/stock/models/product.py

+        self.ensure_one()
+        domain = ['|',
+            ('product_id', '=', self.id),
+            ('category_id', '=', self.product_tmpl_id.categ_id.id)]


domain = [ '|', ('product_id', '=', self.id), ('category_id', '=', self.product_tmpl_id.categ_id.id), ]

is more readable
also i would create an helper to return the action instead of calling the public method of product_tmpl with an argument

in the product_template you could

@api.model def _get_action_view_related_putaway_rules(domain): return { 'name': _('Putaway Rules'), 'type': 'ir.actions.act_window', 'res_model': 'stock.putaway.rule', 'view_type': 'list', 'view_mode': 'list', 'domain': domain, }

and call this helper in the two action_view_related_putaway_rules

sle-odoo · 2019-02-18T10:55:00Z

addons/stock/models/product.py

@@ -593,6 +601,20 @@ def action_open_quants(self):
        action['context'] = {'search_default_internal_loc': 1}
        return action

+    def action_view_related_putaway_rules(self, **params):


we don't usually use **params in Odoo + i don't think it's the proper way to do things in a method called by a button in a form

pleae remove this arg and create a private method to return the action as per my previous comment
thank you :)

addons/stock/models/product_strategy.py

amoyaux · 2019-02-18T14:13:33Z

addons/stock/models/product_strategy.py

+    def _default_category_id(self):
+        if self.env.context.get('active_model') == 'product.category':
+            return self.env.context.get('active_id')
+        return None


You can remove the return None

PutAwayStrategy model was deleted and FixedPutAwayStrategy model was renamed into PutAwayRule. Now, each location can contain multiple putaway rules, each rule applying either on product or on product category. The purpose is to: - Add more visibility on putaway settings (with a stat button on product, product category and location views, and a submenu item in Product configuration menu). - Change putaway model to avoid redundancy. Task #1935169

sle-odoo · 2019-02-25T10:35:38Z

robodoo r+

PutAwayStrategy model was deleted and FixedPutAwayStrategy model was renamed into PutAwayRule. Now, each location can contain multiple putaway rules, each rule applying either on product or on product category. The purpose is to: - Add more visibility on putaway settings (with a stat button on product, product category and location views, and a submenu item in Product configuration menu). - Change putaway model to avoid redundancy. Task #1935169 closes #30889

robodoo · 2019-02-25T11:46:28Z

Merged, thanks!

robodoo added the seen 🙂 label Feb 6, 2019

C3POdoo added the RD research & development, internal work label Feb 6, 2019