[FIX]: Fix the traceback when click on the location and warehouse fil… #31316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppr-odoo
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
from
15e1bd7
to
b7cc33c
Compare
robodoo
added
CI 🤖
ppr-odoo
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
from
b7cc33c
to
2d45534
Compare
robodoo
added
CI 🤖
ppr-odoo
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
from
2d45534
to
ed9d644
Compare
|
Linked to #30368 where |
Whenrow
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
3 times, most recently
from
91fc9ae
to
e8e478c
Compare
sle-odoo
reviewed
May 8, 2019
addons/stock/models/product.py
Outdated
| domain += [('company_id', '=', self.env.context['force_company'])] | ||
| location_ids = self.env['stock.location'].search(domain).ids | ||
|
|
||
| def _search_ids(model, value, force_company_id): |
sle-odoo
reviewed
May 8, 2019
sle-odoo
reviewed
May 8, 2019
addons/stock/models/product.py
Outdated
| domain += [('company_id', '=', self.env.context['force_company'])] | ||
| location_ids = self.env['stock.location'].search(domain).ids | ||
|
|
||
| def _search_ids(model, value, force_company_id): |
There was a problem hiding this comment.
add a comment: dummy field uset in the search view will always return a list of ids or a list of string
Whenrow
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
4 times, most recently
from
a7da4ca
to
7e39727
Compare
|
robodoo r+ |
|
'ci/runbot' failed on this reviewed PR. |
|
'ci/runbot' failed on this reviewed PR. |
1 similar comment
|
'ci/runbot' failed on this reviewed PR. |
Purpose: filter product by location of warehouse failed due to the control panel refactoring (odoo#29106). This commit fix the way the product quantities are computed when location/warehouse into filter context. Task:1941639 Co-Authored-By: Martin Geubelle <mge@odoo.com>
Whenrow
force-pushed
the
saas-12.1-filter-traceback-fix-ppr
branch
from
7e39727
to
5a2bcf8
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 10, 2019
Purpose: filter product by location of warehouse failed due to the control panel refactoring (#29106). This commit fix the way the product quantities are computed when location/warehouse into filter context. Task:1941639 Co-Authored-By: Martin Geubelle <mge@odoo.com> closes #31316 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
|
Staging failed: ci/runbot on 4fd16198707025667427575458e7379912fa7016 (view more at http://runbot.odoo.com/runbot/build/516586) |
|
@robodoo retry |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pad:https://pad.odoo.com/p/r.032e5b9719b7f74f02ff5ca5a1a7e6db
Task:https://www.odoo.com/web#id=1941639&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720