[MERGE] web: update bootstrap from 4.2.1 to 4.3.1

[qsm-odoo]

See https://blog.getbootstrap.com/2019/02/11/bootstrap-4-3-0/
and https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/

Again, some fixes were added in this version and not in a 4.2.x version
so there is no clean way to backport them in 12.0 / saas-12.2.
If needed, the file bootstrap_review.scss is there for that.

Among the new features, two notable ones:

• The '.modal-dialog-scrollable' class which does what odoo already
  implemented for all its modals. So we could remove our custom code in
  a next update.
• Responsive font sizes ! Plan was to develop something similar for the
  website, so this comes at the right time. The behavior is opt-in, we
  will enable it in a next update.

task-1944790

[qsm-odoo]

@robodoo r+

[qsm-odoo]

@robodoo rebase-merge

[robodoo]

Merge method set to rebase and merge, using the PR as merge commit message

[qsm-odoo]

@robodoo r+

[qsm-odoo]

@robodoo r+

[robodoo]

Staging failed: ci/runbot on f62345109ac089a47d779f25253e65afcb138f4a (view more at http://runbot.odoo.com/runbot/build/471230)

[qsm-odoo]

@robodoo retry

[robodoo]

Merged, thanks!

[qsm-odoo]

@d-fence This one too... :)

[d-fence]

Same answer. Non deterministic fails. This bug affects other branches too

[xmo-odoo]

@qsm-odoo was it really a good idea to suppress the deprecation messages for the size builtin instead of surfacing it as a warning & fixing the existing one?

[qsm-odoo]

@xmo-odoo If I remember well, if you wanted to keep deprecation messages, you were stuck with warnings because bootstrap itself uses deprecated methods 🤷. So it was this or patching the lib. Any specific problem with this?

[xmo-odoo]

@xmo-odoo If I remember well, if you wanted to keep deprecation messages, you were stuck with warnings because bootstrap itself uses deprecated methods shrug.

Gah, makes sense then

So it was this or patching the lib. Any specific problem with this?

No specific problem, only fear of what'll happen if we ever get to 5.0 without dropping bootstrap (I'm not quite sure how but I got the message to trigger somehow and went looking for what that was about).