Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for account-pocalypse #31463

Closed
wants to merge 7 commits into from

Conversation

smetl
Copy link
Contributor

@smetl smetl commented Feb 27, 2019

@smetl smetl added RD research & development, internal work Accounting labels Feb 27, 2019
@smetl smetl requested a review from qdp-odoo February 27, 2019 13:41
@qdp-odoo
Copy link
Contributor

@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Feb 27, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Feb 27, 2019
@robodoo robodoo added merging 👷 and removed merging 👷 CI 🤖 Robodoo has seen passing statuses labels Feb 27, 2019
@robodoo
Copy link
Contributor

robodoo commented Feb 27, 2019

Staging failed: ci/runbot on c118d31e449517973934466dfc8376931bccd93c (view more at http://runbot.odoo.com/runbot/build/471292)

if len(lines) > 1:
raise ValidationError(_('A Payment Term should have only one line of type Balance.'))

@api.one
Copy link
Collaborator

@Yenthe666 Yenthe666 Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smetl where we not going to stop with api.one? ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yenthe666 The goal is to move stuff, not to refactor the code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a good moment to touch it in master, not? You're creating a diff already so why not do two things at once 😄 Just my five cents!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yenthe666 Ok ok... you won ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smetl Awesome, I own you a beer on the next OEXP 😉

@smetl smetl force-pushed the master-acc-pocalypse-pre-las branch 2 times, most recently from d58c9b8 to 658d5d4 Compare February 28, 2019 11:08
@smetl smetl force-pushed the master-acc-pocalypse-pre-las branch from 658d5d4 to fb1af78 Compare February 28, 2019 11:08
-incoterm_id in account/models/account_invoice.py
-incoterms_id in sale_stock/models/account_invoice.py
@smetl smetl force-pushed the master-acc-pocalypse-pre-las branch from fb1af78 to 118b10e Compare February 28, 2019 12:33
@qdp-odoo
Copy link
Contributor

@robodoo r+

@qdp-odoo
Copy link
Contributor

@robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Feb 28, 2019

I'm sorry, @qdp-odoo. This PR is already reviewed, reviewing it again is useless.

@robodoo
Copy link
Contributor

robodoo commented Feb 28, 2019

Merge method set to rebase and fast-forward

@smetl
Copy link
Contributor Author

smetl commented Feb 28, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Feb 28, 2019
robodoo pushed a commit that referenced this pull request Feb 28, 2019
-incoterm_id in account/models/account_invoice.py
-incoterms_id in sale_stock/models/account_invoice.py

closes #31463
@robodoo robodoo added merging 👷 and removed merging 👷 CI 🤖 Robodoo has seen passing statuses labels Feb 28, 2019
@robodoo
Copy link
Contributor

robodoo commented Feb 28, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/471963)

@KangOl
Copy link
Contributor

KangOl commented Feb 28, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Feb 28, 2019
robodoo pushed a commit that referenced this pull request Feb 28, 2019
-incoterm_id in account/models/account_invoice.py
-incoterms_id in sale_stock/models/account_invoice.py

closes #31463
@robodoo
Copy link
Contributor

robodoo commented Feb 28, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 28, 2019
@smetl smetl deleted the master-acc-pocalypse-pre-las branch October 7, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accounting CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants