-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for account-pocalypse #31463
Conversation
@robodoo r+ rebase-ff |
Merge method set to rebase and fast-forward |
Staging failed: ci/runbot on c118d31e449517973934466dfc8376931bccd93c (view more at http://runbot.odoo.com/runbot/build/471292) |
if len(lines) > 1: | ||
raise ValidationError(_('A Payment Term should have only one line of type Balance.')) | ||
|
||
@api.one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smetl where we not going to stop with api.one? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yenthe666 The goal is to move stuff, not to refactor the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a good moment to touch it in master, not? You're creating a diff already so why not do two things at once 😄 Just my five cents!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yenthe666 Ok ok... you won ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smetl Awesome, I own you a beer on the next OEXP 😉
'transaction_ids' is a field defined in 'account_payment' but used in 'account'. Then, the portal generates a traceback with only 'account' installed.
d58c9b8
to
658d5d4
Compare
658d5d4
to
fb1af78
Compare
-incoterm_id in account/models/account_invoice.py -incoterms_id in sale_stock/models/account_invoice.py
fb1af78
to
118b10e
Compare
@robodoo r+ |
@robodoo rebase-ff |
I'm sorry, @qdp-odoo. This PR is already reviewed, reviewing it again is useless. |
Merge method set to rebase and fast-forward |
@robodoo retry |
-incoterm_id in account/models/account_invoice.py -incoterms_id in sale_stock/models/account_invoice.py closes #31463
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/471963) |
@robodoo retry |
-incoterm_id in account/models/account_invoice.py -incoterms_id in sale_stock/models/account_invoice.py closes #31463
Merged, thanks! |
task:
https://www.odoo.com/web#id=1917430&action=333&active_id=967&model=project.task&view_type=form&menu_id=4720
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr