[FIX] base_automation: do not read all fields #31737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmo-odoo
reviewed
Mar 11, 2019
vals may be an empty dict This may happen a write is done on a computed field, the call to _write will be empty (still needed to update write_uid/date). Before this commit, all fields were read in the read call. This was unecessary and may produce acess-rights errors or other side effect (e.g. in odoo/enterprise#3778 the technical field ticket_count was read, even if not present in the view or the write call) Only compute old_values on the fields that are modified Fixes odoo/enterprise#3778 opw-1949911
mart-e
force-pushed
the
12.0-base-automation-trigger-write-mat
branch
from
565326d
to
48f42f1
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valsmay be an empty dictThis may happen a write is done on a computed field, the call to
_writewillbe empty (still needed to update
write_uid/date).Before this commit, all fields were read in the read call.
This was unecessary and may produce acess-rights errors or other side effect
(e.g. in odoo/enterprise#3778 the technical field ticket_count was read, even
if not present in the view or the write call)
Only compute old_values on the fields that are modified
Fixes odoo/enterprise#3778
opw-1949911
cc @moylop260