[FIX] l10n_fr_fec: float representation when summing #31755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kebeclibre
force-pushed
the
11.0-fec-rounding-lpe
branch
from
3eb5748
to
207aeaa
Compare
robodoo
added
CI 🤖
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177
nim-odoo
force-pushed
the
11.0-fec-rounding-lpe
branch
from
207aeaa
to
03e2d8d
Compare
robodoo
added
CI 🤖
robodoo
pushed a commit
that referenced
this pull request
Mar 18, 2019
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes #31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
Merged, thanks! |
gurneyalex
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jan 14, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
leemannd
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jan 18, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
jcoux
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jan 19, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jul 29, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jul 29, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jul 29, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jul 29, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
santostelmo
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Jul 29, 2022
Before this commit, it may happen that the the grouped account move lines sum will be business-wise "zero" but that its representation in SQL will not be rather, it will be equal to "10^[-high number]" After this commit, we round the sum to the number of digits of the company's currency to see if it is equal to zero, or not. We also need to filter out the specific case of unaffected earnings OPW 1942177 closes odoo#31755 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it may happen that the the grouped account move lines
sum will be business-wise "zero" but that its representation in SQL will not be
rather, it will be equal to "10^[-high number]"
After this commit, we round the sum to the number of digits of the company's currency
to see if it is equal to zero, or not
OPW 1942177
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr