[FIX] web: update domain when switching between views #31859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's assume the following scenario on an action with two multi records views (e.g. kanban and list). In the kanban view, activate a domain or groupby, switch to list view, remove the domain or groupby, switch back to kanban: the domain or groupby is still applied (even though it's no longer displayed in the search view). This is due to the jQuery update (ab56e63) and the use of native Promises (always async) instead of old jQuery 1.11 Deferreds (which where sync when already resolved). In the new version, the domain/context/groupby were added to the params a 'tick too late', so the view was updated without that information (and thus the old domain/context/groupby were kept). Issue reported on the jquery update pad.
aab-odoo
force-pushed
the
master-jquery-fix-aab
branch
from
1ecf05a
to
91a09d0
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 15, 2019
Let's assume the following scenario on an action with two multi records views (e.g. kanban and list). In the kanban view, activate a domain or groupby, switch to list view, remove the domain or groupby, switch back to kanban: the domain or groupby is still applied (even though it's no longer displayed in the search view). This is due to the jQuery update (ab56e63) and the use of native Promises (always async) instead of old jQuery 1.11 Deferreds (which where sync when already resolved). In the new version, the domain/context/groupby were added to the params a 'tick too late', so the view was updated without that information (and thus the old domain/context/groupby were kept). Issue reported on the jquery update pad. closes #31859 Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's assume the following scenario on an action with two multi
records views (e.g. kanban and list). In the kanban view, activate
a domain or groupby, switch to list view, remove the domain or
groupby, switch back to kanban: the domain or groupby is still
applied (even though it's no longer displayed in the search view).
This is due to the jQuery update (ab56e63) and the use of
native Promises (always async) instead of old jQuery 1.11 Deferreds
(which where sync when already resolved). In the new version, the
domain/context/groupby were added to the params a 'tick too late',
so the view was updated without that information (and thus the old
domain/context/groupby were kept).
Issue reported on the jquery update pad.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr