[IMP] support Access-Control-Allow-Credentials #31899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for CORS was introduced in version 8.0 but there still lack support for with Access-Control-Allow-Credentials header, which is required to access user credentials. This commit aims to support that use-case. useful links: odoo@9cce88a https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials https://www.w3.org/TR/cors/#access-control-allow-credentials-response-header Closes odoo#31899
johandem
force-pushed
the
saas-12.2-cors-credentials-jde
branch
from
bf8c6a8
to
0ad0d42
Compare
|
Coming to this through codetriage.com. Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Support for CORS was introduced in version 8.0 but there still lack support for
with Access-Control-Allow-Credentials header, which is required to access user
credentials.
Current behavior before PR:
No way to set Access-Control-Allow-Credentials header through routing attribute.
Desired behavior after PR is merged:
Introduce new attribute to set Access-Control-Allow-Credentials header.
related specifications
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials
https://www.w3.org/TR/cors/#access-control-allow-credentials-response-header
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr