Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] support Access-Control-Allow-Credentials #31899

Open
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
3 participants
@johandem
Copy link
Contributor

johandem commented Mar 18, 2019

Description of the issue/feature this PR addresses:

Support for CORS was introduced in version 8.0 but there still lack support for
with Access-Control-Allow-Credentials header, which is required to access user
credentials.

Current behavior before PR:

No way to set Access-Control-Allow-Credentials header through routing attribute.

Desired behavior after PR is merged:

Introduce new attribute to set Access-Control-Allow-Credentials header.

related specifications

https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials
https://www.w3.org/TR/cors/#access-control-allow-credentials-response-header

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[IMP] support Access-Control-Allow-Credentials
Support for CORS was introduced in version 8.0 but there still lack support for
with Access-Control-Allow-Credentials header, which is required to access user
credentials.

This commit aims to support that use-case.

useful links:
9cce88a
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials
https://www.w3.org/TR/cors/#access-control-allow-credentials-response-header

Closes #31899

@robodoo robodoo added the seen 🙂 label Mar 18, 2019

@johandem johandem force-pushed the odoo-dev:saas-12.2-cors-credentials-jde branch from bf8c6a8 to 0ad0d42 Mar 18, 2019

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

@C3POdoo C3POdoo added the RD label Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.