[FIX] mail: chatter's attachments & followers alignment on mobile #31939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pparidans
force-pushed
the
saas-12.2-chatter-mobile-broken-app
branch
from
274cd5e
to
39c6069
Compare
robodoo
added
CI 🤖
pparidans
force-pushed
the
saas-12.2-chatter-mobile-broken-app
branch
from
39c6069
to
2836743
Compare
pparidans
force-pushed
the
saas-12.2-chatter-mobile-broken-app
branch
from
2836743
to
4beb748
Compare
Buttons "Send message / Log note / Activity" are on two lines instead of one. In addition there is a 1px glitch on the attachment icon. Also long attachment name on tiny screens (i.e. iPhone 5) breaks the composer layout: horizontal scrollbar appears. The two-line buttons effect is related to a change (fix) in Bootstrap 4.2 which removes the white-space: nowrap on .btn. It was originally introduced in Odoo through odoo#29949. Reference: Original Bootstrap PR twbs/bootstrap#27010 Task ID: 1946573
pparidans
force-pushed
the
saas-12.2-chatter-mobile-broken-app
branch
from
4beb748
to
feac971
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 8, 2019
Buttons "Send message / Log note / Activity" are on two lines instead of one. In addition there is a 1px glitch on the attachment icon. Also long attachment name on tiny screens (i.e. iPhone 5) breaks the composer layout: horizontal scrollbar appears. The two-line buttons effect is related to a change (fix) in Bootstrap 4.2 which removes the white-space: nowrap on .btn. It was originally introduced in Odoo through #29949. Reference: Original Bootstrap PR twbs/bootstrap#27010 Task ID: 1946573 closes #31939 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task ID: 1946573