Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: chatter's attachments & followers alignment on mobile #31939

Closed

Conversation

Projects
None yet
4 participants
@pparidans
Copy link
Contributor

commented Mar 19, 2019

Task ID: 1946573

@robodoo robodoo added the seen 🙂 label Mar 19, 2019

@C3POdoo C3POdoo added the RD label Mar 19, 2019

@robodoo robodoo added the CI 🤖 label Mar 19, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-chatter-mobile-broken-app branch from 274cd5e to 39c6069 Mar 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 19, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-chatter-mobile-broken-app branch from 39c6069 to 2836743 Apr 8, 2019

@robodoo robodoo removed the CI 🤖 label Apr 8, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-chatter-mobile-broken-app branch from 2836743 to 4beb748 Apr 8, 2019

@robodoo robodoo added the CI 🤖 label Apr 8, 2019

@pparidans pparidans requested a review from adr-odoo Apr 8, 2019

[FIX] mail: chatter's button alignment and composer width on mobile
Buttons "Send message / Log note / Activity" are on two lines instead of
one. In addition there is a 1px glitch on the attachment icon.

Also long attachment name on tiny screens (i.e. iPhone 5) breaks the
composer layout: horizontal scrollbar appears.

The two-line buttons effect is related to a change (fix) in Bootstrap
4.2 which removes the white-space: nowrap on .btn. It was originally
introduced in Odoo through #29949.

Reference: Original Bootstrap PR twbs/bootstrap#27010

Task ID: 1946573

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-chatter-mobile-broken-app branch from 4beb748 to feac971 Apr 8, 2019

@robodoo robodoo removed the CI 🤖 label Apr 8, 2019

@adr-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@robodoo robodoo added the r+ 👌 label Apr 8, 2019

robodoo pushed a commit that referenced this pull request Apr 8, 2019

[FIX] mail: chatter's button alignment and composer width on mobile
Buttons "Send message / Log note / Activity" are on two lines instead of
one. In addition there is a 1px glitch on the attachment icon.

Also long attachment name on tiny screens (i.e. iPhone 5) breaks the
composer layout: horizontal scrollbar appears.

The two-line buttons effect is related to a change (fix) in Bootstrap
4.2 which removes the white-space: nowrap on .btn. It was originally
introduced in Odoo through #29949.

Reference: Original Bootstrap PR twbs/bootstrap#27010

Task ID: 1946573

closes #31939

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 8, 2019

@adr-odoo adr-odoo deleted the odoo-dev:saas-12.2-chatter-mobile-broken-app branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.