[FIX] web: click on home menu on next tick #31949
Conversation
| @@ -24,7 +24,7 @@ | |||
| AbstractController.include({ | |||
| start: function(){ | |||
| this.$el.attr('data-view-type', this.viewType); | |||
| return this._super(); | |||
| return this._super(arguments); | |||
There was a problem hiding this comment.
this._super.apply(this, arguments);
| @@ -36,7 +36,7 @@ | |||
| if (Discuss) { | |||
| Discuss.include({ | |||
| _fetchAndRenderThread: function() { | |||
| return this._super().then(function (){ | |||
| return this._super(arguments).then(function (){ | |||
There was a problem hiding this comment.
this._super.apply(this, arguments);
| setTimeout(function(){ | ||
| var $homeMenu = $("nav.o_main_navbar > a.o_menu_toggle.fa-th"); | ||
| $homeMenu.click(); | ||
| }, 0); |
There was a problem hiding this comment.
Does this really work?? This is not what we did earlier.
There was a problem hiding this comment.
Yes it works.
The previous thing was to wait for ".o_home_menu_background" with an interval
There was a problem hiding this comment.
I'm afraid it wasn't. We clicked directly on the button, and then made a Promise that resolved when the home menu was in the DOM, and we returned that promise, making the whole thing wait for it to be displayed before clicking on the next app.
There was a problem hiding this comment.
If this works, it's by chance, and we are still clicking on something that is not in the DOM.
There was a problem hiding this comment.
Ok, I revert with the previous code then.
There was a problem hiding this comment.
$homeMenu.click();
return new Promise(function (resolve) {
setTimeout(resolve, 0);
});
There was a problem hiding this comment.
Hmm, I see, I thought that searching for the home menu in the setTimeout would be sufficient to have it in the DOM
d-fence
force-pushed
the
master-fix-click-all-moc
branch
from
60605e4
to
26763d3
Compare
d-fence
force-pushed
the
master-fix-click-all-moc
branch
from
26763d3
to
5752eb9
Compare
robodoo
added
CI 🤖
Since odoo/enterprise@b830ea7ed2a, the enterprise home menu is asynchrnonous. Because of that, the clientActionCount variable is updated too late and this counter is screwed up, making the test fail. With this commit a setTimeout 0 is used to click on home menu in the next tick and then update the current action count. Also * the test is adapted to stop immediately when an error is catched. * the initial click on home menu is moved into debug manager because the python test launcher uses the correct location already. Thanks to @VincentSchippefilt and @aab-odoo
d-fence
force-pushed
the
master-fix-click-all-moc
branch
from
5752eb9
to
e10c4c2
Compare
robodoo
added
CI 🤖
|
@robodoo r+ |
Since odoo/enterprise@b830ea7ed2a, the enterprise home menu is asynchrnonous. Because of that, the clientActionCount variable is updated too late and this counter is screwed up, making the test fail. With this commit a setTimeout 0 is used to click on home menu in the next tick and then update the current action count. Also * the test is adapted to stop immediately when an error is catched. * the initial click on home menu is moved into debug manager because the python test launcher uses the correct location already. Thanks to @VincentSchippefilt and @aab-odoo closes #31949 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
|
Merged, thanks! |
Since odoo/enterprise@b830ea7ed2a the enterprise home menu is asynchronous.
Because of that, the clientActionCount variable is updated too late and
this counter is screwed up, making the test fail.
With this commit a setTimeout 0 is used to click on home menu in the
next tick and then update the current action count.
Also
the python test launcher user the correct location already.
Thanks to @VincentSchippefilt and @aab-odoo