Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] hr_payroll: Approving a leave deletes overlapping benefits #31997

Closed
wants to merge 1 commit into from
Closed

[FIX] hr_payroll: Approving a leave deletes overlapping benefits #31997

wants to merge 1 commit into from

Commits on Mar 20, 2019

  1. [FIX] hr_payroll: Appoving a leave delete overlapping benefits 

    Steps to reproduce:

1. Generate Benefits for one month
(Don't validate them)

2. Create and validate a leave in that month

Current behavior: Benefits overlapping the leave are not deleted.
Expected behaviour: Benefits are deleted and a new benefit
of type leave is created instead.

Fix: compute conflicting benefits before approving
a leave to allow the normal conflict resolution
mechanism to handle the issue.

Note: this fix is suboptimal and a better fix should be
done in master.
    @LucasLefevre
    LucasLefevre committed Mar 20, 2019
    Copy the full SHA
    b4f2cff View commit details
    Browse the repository at this point in the history