Optimization of settings atrs to current thread.

[heckad]

No needed call slow threading.current_thread() on evry arg setting.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[mart-e]

Hello,

Thank you for you patch but it seems you have not signed the CLA.
Could you add it so we can integrate your patch?
Regards

[Xavier-Do]

Hello

As far as I remember we took a quick look at the current_thread() implementation and it was quite light, but I may be wrong about that.
Could you explain why you consider it as slow?
After a quick testing, I have not more than twice the time of an access to a stored current_thread compared to the threading.current_thread() method:

import time
import threading 

ct = threading.current_thread()
def perfs(func, iter = 10000000):
    init = time.time()
    for i in range(0, iter):
        func()
    print('Finished %s in %s s' % (iter, (time.time()-init)))

def current_thread():
    return ct
    
perfs(threading.current_thread)
perfs(current_thread)

Results:

Finished 10000000 in 1.65838980675 s
Finished 10000000 in 0.879067182541 s

I tested with python2.7 and 3.7 and results are similar.

I don't mean that your suggestion is wrong but I'd like to understand why you consider that current_thread() is "slow" and if you have an example use case so that we can write a explanatory commit message.

[heckad]

Function threading.current_thread gets value from the dict. Good practice to get ref to the value and use this ref for manipulating them, not to get it from dict for manipulation. It`s just faster.

[mart-e]

Thanks for the clarification. It makes no noticable difference for the performance but is a nice code cleaning.

@robodoo r+

[robodoo]

Because this PR has multiple commits, I need to know how to merge it:

• merge to merge directly, using the PR as merge commit message
• rebase-merge to rebase and merge, using the PR as merge commit message
• rebase-ff to rebase and fast-forward

[mart-e]

robodoo rebase-ff

[robodoo]

Merge method set to rebase and fast-forward

[robodoo]

Merged, thanks!