[FIX] account: Remove partner on changing partner_type or payment_type

[sswapnesh]

Description of the issue/feature this PR addresses: Account module (Customer/Vendor Payment)

Current behavior before PR:

• Create Payment (Customer)
• Select Partner Type --> Customer
• Select Partner --> It will be Customer (As domain will be applied based on Partner Type)
• Change Partner Type -->Vendor

Still Customer is there which should be removed as Partner Type is changed now

Desired behavior after PR is merged: Remove partner when partner_type or payment_type is changed

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[MiquelRForgeFlow]

Why not self.env["res.partner"] as an empty record?

[sswapnesh]

Does it makes any difference? (Can you explain if it makes any)

[MiquelRForgeFlow]

The difference is that False is a boolean, so for example, if you do later (in another onchange or some other place) self.partner_id.company_id, then it will break, as boolean doesn't have company_id field. But if you do as empty record, then it doesn't break.

[sswapnesh]

Thanks
Let's see what odoo says on this.

[sswapnesh]

Ping @qdp-odoo

[qdp-odoo]

I dunno

@avw-odoo ?

[sswapnesh]

Or Maybe @mart-e can verify.

[sswapnesh]

or Maybe someone from accounting team ✋
/cc @smetl @csnauwaert

[smetl]

If your partner is both a customer/vendor, why removing it?

[sswapnesh]

If your partner is both a customer/vendor, why removing it?

Ideally, Partner shouldn't be removed but handling that case would be too much for Stable version.

IMO, This is enough to Prevent wrong Payment where Customer/Supplier are Identical.

@smetl Do you want me to go ahead and fix this entirely ? (To handle the case where Partner is Customer and Supplier)

[smetl]

Let's check with @avw-odoo

[sswapnesh]

@avw-odoo Can you please look into that? (At least for v13)

[smetl]

@sswapnesh In 13.0, partner_type disappeared (customer & vendor)

[sswapnesh]

Oh yes, You are Right.
I will check all these again.
Let's close it than.

[sswapnesh]

Actually this was for 12.0

[smetl]

@sswapnesh Discussed with @avw-odoo . We decide to not change the actual behavior.