[FIX] hr_holidays: use api model instead of multi for dashboard #32119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 1ced3bf, the get_days_all_request method was called with the context as an argument. As a consequence, because of the api.multi, the first arg is used as the ids of the record. As the id is not used in this method, it was not harmful. With the above mentioned fix, there is no more argument. This causes a traceback when clicking on menu "My Time Off/Dashboard". With this commit, the api.model is used instead, that way, the first arg is not considered as ids.
|
Maybe we should also consider changing _get_contextual_employee_id to an api.model method I will integrate that in here as I'm currently working on the dashboard (odoo-dev@6ba2bd7) As this causes a traceback, feel free to merge it |
|
@RomainLibert thanks |
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2019
Before 1ced3bf, the get_days_all_request method was called with the context as an argument. As a consequence, because of the api.multi, the first arg is used as the ids of the record. As the id is not used in this method, it was not harmful. With the above mentioned fix, there is no more argument. This causes a traceback when clicking on menu "My Time Off/Dashboard". With this commit, the api.model is used instead, that way, the first arg is not considered as ids. closes #32119 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 1ced3bf, the get_days_all_request method was called with the
context as an argument. As a consequence, because of the api.multi, the
first arg is used as the ids of the record. As the id is not used in
this method, it was not harmful. With the above mentioned fix, there is
no more argument. This causes a traceback when clicking on menu "My Time
Off/Dashboard".
With this commit, the api.model is used instead, that way, the first arg
is not considered as ids.