[FIX] base_geolocalize: raise a helpful error to configure the Google… #32162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
len-foss
force-pushed
the
10.0-opw1946485-gog-len
branch
from
a93dd59
to
216bf24
Compare
robodoo
added
CI 🤖
nim-odoo
approved these changes
Mar 29, 2019
… account Google maps used to be free, but became a paid API. Technically, the usage could be part of the free offer, but to benefit from it the account needs to have billing enabled. Since it's a paid feature security had to be ramped up, so now APIs have to be explicitly enabled (here geolocating/geocoding). All this makes it so that the Google account has to be properly configured before the calls to the Maps API can work. As a result we add an explicit UserError if the request fails, to help the user configure the Google account (before the error was entirely hidden as to give the user no chance at all). Also exports transaltions, including for commit e6ca846 which raised a similar error message if no API key was found. opw 1946485 opw 1947292 opw 1947337
len-foss
force-pushed
the
10.0-opw1946485-gog-len
branch
from
216bf24
to
29f0c39
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 29, 2019
… account Google maps used to be free, but became a paid API. Technically, the usage could be part of the free offer, but to benefit from it the account needs to have billing enabled. Since it's a paid feature security had to be ramped up, so now APIs have to be explicitly enabled (here geolocating/geocoding). All this makes it so that the Google account has to be properly configured before the calls to the Maps API can work. As a result we add an explicit UserError if the request fails, to help the user configure the Google account (before the error was entirely hidden as to give the user no chance at all). Also exports transaltions, including for commit e6ca846 which raised a similar error message if no API key was found. opw 1946485 opw 1947292 opw 1947337 closes #32162 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
ecino
pushed a commit
to CompassionCH/odoo
that referenced
this pull request
Nov 22, 2019
… account Google maps used to be free, but became a paid API. Technically, the usage could be part of the free offer, but to benefit from it the account needs to have billing enabled. Since it's a paid feature security had to be ramped up, so now APIs have to be explicitly enabled (here geolocating/geocoding). All this makes it so that the Google account has to be properly configured before the calls to the Maps API can work. As a result we add an explicit UserError if the request fails, to help the user configure the Google account (before the error was entirely hidden as to give the user no chance at all). Also exports transaltions, including for commit e6ca846 which raised a similar error message if no API key was found. opw 1946485 opw 1947292 opw 1947337 closes odoo#32162 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… account
Google maps used to be free, but became a paid API.
The hold dealer's tactic of getting'em hooked on the stuff for free,
and then you make them pay once dependant. Great business model.
Technically, the usage could be part of the free offer,
but to benefit from it the account needs to have billing enabled.
Since it's a paid feature security had to be ramped up,
so now API have to be explicitly enabled (here geolocating/geocoding).
All this makes it so that the Google account has to be properly configured
before the calls to the Maps API can work.
As a result we add an explicit UserError if the request fails,
to help the user configure the Google account
(before the error was entirely hidden as to give the user no chance at all).
opw 1946485
opw 1947292
opw 1947337
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr