Master theme issues var #32359
Closed
Master theme issues var #32359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-odoo
force-pushed
the
master-theme-issues-var
branch
from
534c9cc
to
db4c53f
Compare
robodoo
added
CI 🤖
var-odoo
force-pushed
the
master-theme-issues-var
branch
from
db4c53f
to
296769c
Compare
robodoo
added
CI 🤖
dharmrajsinh-jhala
force-pushed
the
master-theme-issues-var
branch
from
296769c
to
b1a8e47
Compare
dharmrajsinh-jhala
force-pushed
the
master-theme-issues-var
branch
from
b1a8e47
to
66c3125
Compare
dharmrajsinh-jhala
force-pushed
the
master-theme-issues-var
branch
from
66c3125
to
61ad850
Compare
qsm-odoo
requested changes
Apr 16, 2019
addons/event/controllers/main.py
Outdated
| @@ -9,7 +9,7 @@ | |||
| class EventController(Controller): | |||
|
|
|||
| @route(['''/event/<model("event.event", "[('state', 'in', ('confirm', 'done'))]"):event>/ics'''], type='http', auth="public") | |||
| def event_ics_file(self, event): | |||
| def event_ics_file(self, event, **kwargs): | |||
| @@ -1050,6 +1050,12 @@ table.table_desc tr td { | |||
| background: $light; | |||
| margin-top: -999px; | |||
| transition: margin-top 500ms ease 0s; | |||
| @include media-breakpoint-down(md) { | |||
There was a problem hiding this comment.
To check but I really it is sm
dharmrajsinh-jhala
force-pushed
the
master-theme-issues-var
branch
from
61ad850
to
ffc0cff
Compare
robodoo
added
CI 🤖
qsm-odoo
approved these changes
Apr 18, 2019
|
@robodoo r- |
qsm-odoo
requested changes
Apr 18, 2019
There was a problem hiding this comment.
@dja-odoo Commit message is nearly great, just a small detail: the verb which starts the commit title should not be conjugated (so here, it should be "make"). The title should be such as it completes the sentence "If applied, this commit will ..." -> "make hamburger menu ..." :)
Also, there is a small typo at the end -> scrollable
Could you fix that (also, the same goes for the other PR of this task). Thank you ! :)
Currently, in small devices, hamburger menu of the cloned navbar is not scrollable due to fixed position. This commit improves the behavior and makes the affixed navbar scrollable, enabling user to navigate through all the available menus. task-1938637
dharmrajsinh-jhala
force-pushed
the
master-theme-issues-var
branch
from
ffc0cff
to
ce374f7
Compare
|
@qsm-odoo I've changed the commit messages :) Could you have a look ? Thanks :) |
qsm-odoo
approved these changes
Apr 18, 2019
robodoo
pushed a commit
that referenced
this pull request
Apr 18, 2019
Currently, in small devices, hamburger menu of the cloned navbar is not scrollable due to fixed position. This commit improves the behavior and makes the affixed navbar scrollable, enabling user to navigate through all the available menus. task-1938637 closes #32359 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task: https://www.odoo.com/web#id=1938637&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.800ba7770c62ede5fd8eb79362d031fa
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr