Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock: scrap and validate #32410

Closed
wants to merge 1 commit into from

Conversation

nim-odoo
Copy link
Contributor

@nim-odoo nim-odoo commented Apr 4, 2019

  • Sell 4 units of a product in stock
  • On the picking, create a scrap for 1 unit
  • Validate
  • In the immediate transfer wizard, validate

The scrap is reset to zero.

This is because the wizard overwrite the done quantity with the reserved
quantity (0.0).

If the move is already done, there is no reason to overwrite the
quantity.

opw-1958514

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

- Sell 4 units of a product in stock
- On the picking, create a scrap for 1 unit
- Validate
- In the immediate transfer wizard, validate

The scrap is reset to zero.

This is because the wizard overwrite the done quantity with the reserved
quantity (0.0).

If the move is already done, there is no reason to overwrite the
quantity.

opw-1958514
@nim-odoo nim-odoo self-assigned this Apr 4, 2019
@nim-odoo nim-odoo added the OE the report is linked to a support ticket (opw-...) label Apr 4, 2019
@nim-odoo
Copy link
Contributor Author

nim-odoo commented Apr 4, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 4, 2019
robodoo pushed a commit that referenced this pull request Apr 4, 2019
- Sell 4 units of a product in stock
- On the picking, create a scrap for 1 unit
- Validate
- In the immediate transfer wizard, validate

The scrap is reset to zero.

This is because the wizard overwrite the done quantity with the reserved
quantity (0.0).

If the move is already done, there is no reason to overwrite the
quantity.

opw-1958514

closes #32410

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses merging 👷 and removed merging 👷 labels Apr 4, 2019
@robodoo
Copy link
Contributor

robodoo commented Apr 4, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 4, 2019
@nim-odoo nim-odoo deleted the 11.0-opw-1958514-scrap_done-nim branch April 4, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants