Master mrp improve ui jip #32785

jip-odoo · 2019-04-18T05:43:24Z

Task: https://www.odoo.com/web?#id=1949618&action=327&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.a80bef5d908739485b8ca61ee4595be8

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

fmdl · 2019-04-24T20:07:14Z

addons/mrp/models/mrp_production.py

@@ -200,6 +200,12 @@ def _get_default_location_dest_id(self):
    production_location_id = fields.Many2one('stock.location', "Production Location", related='product_id.property_stock_production', readonly=False)
    picking_ids = fields.Many2many('stock.picking', compute='_compute_picking_ids', string='Picking associated to this manufacturing order')
    delivery_count = fields.Integer(string='Delivery Orders', compute='_compute_picking_ids')
+    is_ready_produce = fields.Boolean(compute='_compute_is_ready_produce', default=False)


default=False is useless, no ?

fmdl · 2019-04-24T20:17:43Z

addons/mrp/models/mrp_production.py

+    @api.depends('move_raw_ids', 'move_raw_ids.reserved_availability')
+    def _compute_is_ready_produce(self):
+        for order in self:
+            order.is_ready_produce = all(move.bom_line_id.product_qty <= move.reserved_availability for move in order.move_raw_ids) 


becarefull all([]) = True

why use bom_line_id.product_qty; you can modifiy (or delete) the value of quantity or the unit on the bom line, just use move.product_uom_qty, no ?

avoid useless compute if it is an done or cancel order

for order in self.filtered(lambda x: x.state not in ('xxxx')): order.is_ready_produce = all(move.product_qty <= move.reserved_availability for move in order.move_raw_ids)

all([]) is not possible in Confirmed state because manufacturing order always have raw materials in Confirmed state
here , we don't want to modify or delete the value of quantity.
we are just comparing the move.bom_line_id.product_qty and move.reserved_availability to know whether reserved_availability is enough.

move.bom_line_id.product_qty is not a fixed value, you can lauch a manufacturing order, then modifiy the bom, and your compute will be wrong, it think you need to use move.product_qty ormove.product_uom_qty , check what is made on stock.picking.

Your case is right ( if some one change current production bom ) ... but we can not use
move.product_qty <= move.reserved_availability. also reserve quantity will not greater
in any case then move quantity

We can use unit_factor <= reservered ( factor will not change when bom change )

you can also delete a bom line, after lauching MO. That why it is not relevant to use bom_line, it is better to user the state of the move.

fmdl · 2019-04-24T20:19:17Z

addons/mrp/security/mrp_security.xml

@@ -25,6 +25,10 @@
        <field name="category_id" ref="base.module_category_hidden"/>
    </record>

+    <record id="make_invisible" model="res.groups">


use base.group_no_one

fmdl · 2019-04-24T20:19:42Z

addons/mrp/views/mrp_views_menus.xml

@@ -37,6 +37,7 @@

        <menuitem id="menu_view_resource_calendar_search_mrp"
            action="resource.action_resource_calendar_form"
+            groups="make_invisible"


use base.group_no_one

fmdl · 2019-04-25T11:49:49Z

addons/mrp/models/mrp_production.py

@@ -200,6 +200,13 @@ def _get_default_location_dest_id(self):
    production_location_id = fields.Many2one('stock.location', "Production Location", related='product_id.property_stock_production', readonly=False)
    picking_ids = fields.Many2many('stock.picking', compute='_compute_picking_ids', string='Picking associated to this manufacturing order')
    delivery_count = fields.Integer(string='Delivery Orders', compute='_compute_picking_ids')
+    is_ready_produce = fields.Boolean(compute='_compute_is_ready_produce')


use has_ready_produce (like this https://github.com/odoo/odoo/blob/master/addons/stock/models/stock_picking.py#L278)

fmdl · 2019-04-25T13:49:01Z

addons/mrp/models/mrp_production.py

+    def _compute_is_ready_produce(self):
+        for order in self:
+            if order.state not in ('draft', 'done', 'cancel'):
+                order.is_ready_produce = all(move.bom_line_id.product_qty <= move.reserved_availability for move in order.move_raw_ids)


You just need to check the state of move with a bilt-in methode: https://github.com/odoo/odoo/blob/master/addons/stock/models/stock_move.py#L588

for order in self.filtered(lambda x: x.state not in ('draft', 'done', 'cancel')): order.has_ready_produce = order.move_raw_ids._get_relevant_state_among_moves() == 'assigned'

@jip-odoo, what do you think ?

We don't need moves with full availability if partial available then also we can move to production.

use also partially_available
order.move_raw_ids._get_relevant_state_among_moves() in ('assigned', 'partially_available')

@fmdl @sle-odoo Can we start production without minimum quantity requirement satisfied?

if yes then we will go with state...

Also another case I need 5 unit of component and it reserved 1 unit.
After consumption, we don't have to consider this as ready ( we have to consider done quantity after consumption )

it depends on a settings on the bom right? if the move is partially available but has enough reserved components to produce 1 unit, then it should be ready

task-1949618

-also improve tooltip on attachment icon -and also hide attachment count in edit mode task-1949618

task-1949618

-apply group_stock_multi_locations group on Miscellaneous tab task-1949618

task-1949618

-'Working Times' -'Productivity Losses' task-1949618

-'Waiting for Material' > 'Waiting for Component' -'Material Available' > 'Component Available' task-1949618

task-1949618

sle-odoo · 2019-08-28T13:22:20Z

robodoo r+ rebase-ff

robodoo · 2019-08-28T13:23:28Z

Merge method set to rebase and fast-forward

task-1949618 closes #32785 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

robodoo · 2019-08-28T14:21:31Z

Merged at 85b5c9b, thanks!

robodoo added the seen 🙂 label Apr 18, 2019

C3POdoo added the RD research & development, internal work label Apr 18, 2019

robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 18, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from b04d5d4 to d60dbdd Compare April 19, 2019 12:10

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 19, 2019

fmdl reviewed Apr 24, 2019

View reviewed changes

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from d60dbdd to f7b9dfa Compare April 25, 2019 07:06

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from f7b9dfa to 1ad8c2d Compare April 25, 2019 09:40

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 1ad8c2d to 4a749c0 Compare April 25, 2019 12:00

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019

fmdl suggested changes Apr 25, 2019

View reviewed changes

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 4a749c0 to 4a97179 Compare April 26, 2019 09:54

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 26, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 4a97179 to bb2cbba Compare May 7, 2019 05:15

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 7, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from bb2cbba to 2053164 Compare May 7, 2019 07:00

robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 7, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 2053164 to 7e44c82 Compare May 7, 2019 07:30

robodoo added the CI 🤖 Robodoo has seen passing statuses label May 7, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 7e44c82 to 23c977a Compare May 27, 2019 05:34

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 27, 2019

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Aug 28, 2019

jip-odoo added 5 commits August 28, 2019 14:52

[IMP] mrp: improve help message on MO

9c88eac

task-1949618

[IMP] mrp: hide attachment icon in edit mode

e4255e3

-also improve tooltip on attachment icon -and also hide attachment count in edit mode task-1949618

[IMP] mrp: hide UNLOCK button in draft state

ff30ddf

task-1949618

[IMP] mrp: hide 'Material Availability' field in form view

d8785a0

-apply group_stock_multi_locations group on Miscellaneous tab task-1949618

[IMP] mrp: change position of CANCEL button on MO

a768e17

task-1949618

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from 1f2d46f to d19c16d Compare August 28, 2019 09:24

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Aug 28, 2019

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from d19c16d to c8f69f2 Compare August 28, 2019 09:54

robodoo added the CI 🤖 Robodoo has seen passing statuses label Aug 28, 2019

jip-odoo added 5 commits August 28, 2019 17:47

[IMP] mrp: stay UPDATE button in edit or read mode on MO

a5cd8e4

task-1949618

[IMP] mrp: remove unnecessary menus from MRP Configuration

e051b35

-'Working Times' -'Productivity Losses' task-1949618

[IMP] mrp: rename filters

6ef9a01

-'Waiting for Material' > 'Waiting for Component' -'Material Available' > 'Component Available' task-1949618

[IMP] mrp: 'Quality' option always visible in settings

7445539

task-1949618

[ADD] mrp: add BOM Type field on BOM tree view

e7dd5cf

task-1949618

jip-odoo force-pushed the master-mrp-improve-ui-jip branch from c8f69f2 to e7dd5cf Compare August 28, 2019 12:23

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Aug 28, 2019

robodoo added the r+ 👌 label Aug 28, 2019

robodoo pushed a commit that referenced this pull request Aug 28, 2019

[ADD] mrp: add BOM Type field on BOM tree view

85b5c9b

task-1949618 closes #32785 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

robodoo added merging 👷 and removed merging 👷 labels Aug 28, 2019

robodoo closed this Aug 28, 2019

fw-bot deleted the master-mrp-improve-ui-jip branch October 19, 2019 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master mrp improve ui jip #32785

Master mrp improve ui jip #32785

jip-odoo commented Apr 18, 2019

fmdl Apr 24, 2019

jip-odoo Apr 25, 2019

fmdl Apr 24, 2019

jip-odoo Apr 25, 2019

fmdl Apr 25, 2019

jir-odoo May 7, 2019

fmdl May 7, 2019

fmdl Apr 24, 2019

jip-odoo Apr 25, 2019

fmdl Apr 24, 2019

jip-odoo Apr 25, 2019

fmdl Apr 25, 2019

fmdl Apr 25, 2019

fmdl May 6, 2019

jir-odoo May 7, 2019

fmdl May 7, 2019

jir-odoo May 15, 2019 •

edited

Loading

sle-odoo May 15, 2019

sle-odoo commented Aug 28, 2019

robodoo commented Aug 28, 2019

robodoo commented Aug 28, 2019

Master mrp improve ui jip #32785

Master mrp improve ui jip #32785

Conversation

jip-odoo commented Apr 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jir-odoo May 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sle-odoo commented Aug 28, 2019

robodoo commented Aug 28, 2019

robodoo commented Aug 28, 2019

jir-odoo May 15, 2019 •

edited

Loading