[FIX] web: date field in calendar no tz issue #32796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nle-odoo
force-pushed
the
11.0-web-opw-196987-nle
branch
from
16a2baa
to
0759e1a
Compare
nle-odoo
force-pushed
the
11.0-web-opw-196987-nle
branch
from
0759e1a
to
97c5191
Compare
adr-odoo
reviewed
Apr 24, 2019
| }, | ||
| session: { | ||
| getTZOffset: function () { | ||
| return -2400; // 40 hours timezone |
There was a problem hiding this comment.
It doesn't represent reality...
There was a problem hiding this comment.
changed to 120 (2 hours) so without the test fail with [day before expected days] 22:00:00 instead of with the fix: [expected day] 00:00:00
|
nle-odoo
force-pushed
the
11.0-web-opw-196987-nle
branch
from
97c5191
to
6228829
Compare
|
thanks updated, the commit in 6228829b5ccc1 and the missing number on opw was a typo, this was opw-1969876 and commit message has been updated |
The calendar should send to server: - for an all day event (all_day field on view): the date in UTC (ie. if we are on 22 august 2018 on UTC+2, not send 21 august 2018 22:00) - for a datetime event not all day: the UTC datetime corresponding to UTC (for 03:25 with UTC+5 timezone, we send 22:25 the day before) - for a date event: the date in UTC (ie. same as all day) The current code was alright for datetime, but there was a missing case if the start_date was a Date field (eg. project task calendar view uses a date_deadline Date field) and not a Datetime field. This changeset apply the same behavior as an all_day event to a calendar with a start date that is a Date field. Note: the issue happen since 11.0's 03d74f4 (26th march 2019) that solved a similar case but for datetime (a datetime event at 8:00 with timezone UTC+9 would be moved the previous day when drag and dropped on the month view). opw-1969876 opw-1971106 opw-1971019 closes odoo#32796
nle-odoo
force-pushed
the
11.0-web-opw-196987-nle
branch
from
6228829
to
011998d
Compare
adr-odoo
approved these changes
Apr 24, 2019
robodoo
pushed a commit
that referenced
this pull request
Apr 24, 2019
The calendar should send to server: - for an all day event (all_day field on view): the date in UTC (ie. if we are on 22 august 2018 on UTC+2, not send 21 august 2018 22:00) - for a datetime event not all day: the UTC datetime corresponding to UTC (for 03:25 with UTC+5 timezone, we send 22:25 the day before) - for a date event: the date in UTC (ie. same as all day) The current code was alright for datetime, but there was a missing case if the start_date was a Date field (eg. project task calendar view uses a date_deadline Date field) and not a Datetime field. This changeset apply the same behavior as an all_day event to a calendar with a start date that is a Date field. Note: the issue happen since 11.0's 03d74f4 (26th march 2019) that solved a similar case but for datetime (a datetime event at 8:00 with timezone UTC+9 would be moved the previous day when drag and dropped on the month view). opw-1969876 opw-1971106 opw-1971019 closes #32796 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calendar should send to server:
we are on 22 august 2018 on UTC+2, not send 21 august 2018 22:00)
UTC (for 03:25 with UTC+5 timezone, we send 22:25 the day before)
The current code was alright for datetime, but there was a missing case
if the start_date was a Date field and not a Datetime field that is
fixed with this changeset.
opw-1969876
opw-1971106
opw-1971019