[FIX] sale_timesheet: update delivered quantities when changing the s… #32820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ale_line_id Create a SO with two lines (sol_1, sol_2) selling a given service. On the corresponding Project/Task, set the partner so that the sale_line_id can be chosen to one of the lines. Add an AAL with x hours, save. This updates the delivered quantity (x) on sol_1. Edit, change the sale_line_id to the second one: it updates the delivered quantity on sol_2 (to x) but not on sol_1. Has a result, the delivered quantity has been doubled. The issue is that the quantities are only recomputed on the SOL that we write; instead they should be recomputed on the old one and the new one. We base ourselves on 371a92f which solved a similar bug to add the recompute on both lines. opw 1959509 11.0-opw1959509-sltmsht-len
simongoffin
approved these changes
Apr 23, 2019
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 23, 2019
…ale_line_id Create a SO with two lines (sol_1, sol_2) selling a given service. On the corresponding Project/Task, set the partner so that the sale_line_id can be chosen to one of the lines. Add an AAL with x hours, save. This updates the delivered quantity (x) on sol_1. Edit, change the sale_line_id to the second one: it updates the delivered quantity on sol_2 (to x) but not on sol_1. Has a result, the delivered quantity has been doubled. The issue is that the quantities are only recomputed on the SOL that we write; instead they should be recomputed on the old one and the new one. We base ourselves on 371a92f which solved a similar bug to add the recompute on both lines. opw 1959509 11.0-opw1959509-sltmsht-len closes #32820 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ale_line_id
Create a SO with two lines (sol_1, sol_2) selling a given service.
On the corresponding Project/Task, set the partner so that the sale_line_id
can be chosen to one of the lines.
Add an AAL with x hours, save.
This updates the delivered quantity (x) on sol_1.
Edit, change the sale_line_id to the second one:
it updates the delivered quantity on sol_2 (to x) but not on sol_1.
Has a result, the delivered quantity has been doubled.
The issue is that the quantities are only recomputed on the SOL that we write;
instead they should be recomputed on the old one and the new one.
We base ourselves on 371a92f which solved a similar bug to add the recompute on
both lines.
opw 1959509
11.0-opw1959509-sltmsht-len
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr