Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master post mortem crash manager adt #32876

Closed

Conversation

Elkasitu
Copy link
Contributor

@Elkasitu Elkasitu commented Apr 23, 2019

  • add description option, to be injected into the CrashManager's body
  • rename name to label
  • rename act_xmlid field to action
  • log deactivated automated actions
  • tests
  • simplify spec

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 23, 2019
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 23, 2019
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from fd21557 to 13a333f Compare April 24, 2019 11:59
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2019
@Elkasitu Elkasitu marked this pull request as ready for review April 24, 2019 12:09
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from 13a333f to 15c7659 Compare April 24, 2019 13:10
@Elkasitu Elkasitu requested a review from lcontzen April 25, 2019 08:49
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from 15c7659 to bd82098 Compare April 25, 2019 11:13
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from ba25a5e to f798e5a Compare May 2, 2019 09:51
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 2, 2019
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from f798e5a to 6759158 Compare May 2, 2019 10:01
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label May 2, 2019
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from 6759158 to 0de3a60 Compare May 3, 2019 14:03
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 3, 2019
sergio-teruel and others added 23 commits June 12, 2019 08:54
Allow to create a specific procurement group for
each so line. The purpose for different group is to
have a specific behavior for each delivery depending
it's group. It also allow to pass extra values to
procurement group creation that would be common between
multiple line (instead of passing the common values to
each lines values argument).

closes odoo#33765

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
…g bar

Previously, online payment option was only activated with
options which are predefined such as (paypal, stripe or manual).
but not with other payment acquirer settings

so now online payment will be activated with all the options including
'Pay with another payment acquirer'

Removed deadcode as following,
method _on_save_payment_acquirer as sale_payment module is removed.
method onchange_portal_confirmation_pay as the field
module_sale_payment is removed.

task-1945749
closes: odoo#33384

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
The _get_asset method was deprecated since df4072b
Last use of this deprecated method was removed with d7da1d6

Also, remains and to_html were deprecated since 9cd982b
test_assetsbundle was still using the deprecated method to test..

Closes odoo#33432

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Purpose
=======

An employee and its current contract should have the same
calendar. Currently, if the contract's calendar is changed,
the employee's calendar is not changed.
In the same way, if a contract is created directly in `open`
state, the employee's calendar is not changed.
Finally, the calendar synchronization when the employee
contract is changed is only done in payroll, for no reason.

Specification
=============

Fix the three issues described above.

If the employee's calendar is nonetheless manually changed, a warning
should be displayed if there is a mismatch between both calendars.
Before this commit, when we want to make an external url, we need to know
if the record is related to a specific website or not, and choose base_url
or website domain.

Now each model have a fonction get_base_url (public to be callable from email
template, ...) and website override this function to add the website domain if
the record is website specific.

closes odoo#34089

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Purpose of the commit is to clean the current portal right of
timesheet(analytic account line) and analytic account(no more ir.rule).

the idea is to remove ir.rule since the domain will be difficult with ir.rule
extension mecanism. Moreover, as this is "technical" data, we will use 'sudo' controller.
as we don't want to customize what is shown in portal.
End user is free to create its own ir.rule to connect odoo in xmlrpc
he will be the only responsible for that.

task-1932488
Purpose of the commit is to add a timesheet section on portal
where you can see all the timesheets and user can see and use the filter
options on them (available when only hr_timesheet is installed)

task-1932488
purpose of the commit is to show the timsesheet related to respective invoice
when invoicing based on delivered quantities,
only show those that have been invoiced

and also allow portal user to see
"(timesheet of visible task OR linked to portal's invoices) AND (billable_type in [billable_time, non_billable])"

task-1932488
Requested in issue odoo#28729

closes odoo#34114

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
The use of polib as introduced in commit 632fa04.
The nightly packaging system uses Docker to test the packages and they need to
be updated when a new library dependency is introduced.

closes odoo#34117

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Replace the email template content form if you have any question to if you have any questions.

task-1962924

Closes odoo#33520

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Before this commit, copying a template with variants would not copy the
attributes lines, so it didn't work as expected.

closes odoo#34128

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
When an invoice is set on a pos config, it is not set on the invoice
generatde from a pos order.

So we are now storing the pos config sale team on the invoice instead of
the default sales team.

TASK-ID: 1998051

closes odoo#33985

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
while creating the event directly from calendar it opens a
quick create with summary field which is not mandatory.

Task-1917002

closes odoo#31236

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
* = mrp, sale, website_forum, website_sale, website_sale_comparison

closes odoo#34121

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Because when the user comes from the sales order and click on product
variant name it will redirect on the product template page, so it looks weird.

Revert commit : odoo@7d581fa

task-1968151

closes odoo#33368

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
* = account, mrp, purchase_stock, sale, sale_product_configurator,
stock_account, website_sale

It is always better to create the product template attribute lines before
creating the variants. In a following commit, this will become mandatory.

The variants that are created should always match the combination of attributes
set on the template.

Finally explicitly call `create_variant_ids` when possible instead of reassigning
the attribute lines to implicitly call `create_variant_ids`.

closes odoo#34122

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
When you had several forums, they were displayed according to the
creation order. Now, you can define a sequence on them and order forums.

task-2007173

closes odoo#34184

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
The old tree views don't really exist anymore, this odd pseudo-flag to
dispatch between "list" and "tree" tree views has no reason to remain.

Task 1937686

closes odoo#31243

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Impacted modules: hr_timesheet and sale_timesheet

This merge provides the customer portal part to display timesheets. Timesheets
can be seen from 3 differents points of view: list of timesheets, timesheets on
tasks, and timesheet linked to invoices (only for delivered qty policy).

When tracking time (sale_timesheet not installed), all timesheets can be displayed
to portal. When sale_timesheet is installed, if the timesheet is billed (billable_type
field), we only display the ones coming from a delivered qty policy selling. Indeed,
it makes no sense to display the 'ordered qty' timesheets, as it can reveal you sold
more time than required to your customer.

To do, we decided to remove access rules for portal user: timesheet (analytic line
model) is now technical and is given with `sudo` to portal. Admin can still restore
some of them to allow third part application with XML RPC.

See subcommits for more details

Task-1932488

closes odoo#31703

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
With this commit, it is possible for the CrashManager to propose actions
to the user(s) concerned by the crash/error.

If whatever triggered the exception properly wraps the exception with a
`metadata` attribute, the web client will display an extra button
in the error dialog, which will then launch an action programmed
by a developer.

This action can be anything, from a server action, to a view action, to
a redirect action...

This `metadata` attribute is essentially a dictionary containing up to 4
entries, those that are required are marked with (*):

    - label (*) : the label of the button displayed on the CrashManager
    that will trigger the action
    - action (*) : an action xmlid or a dict representing an action
    - options : any additional context data for the execution of the action
    - visible : whether the button should be visible or not, e.g. by
    checking that the current user has the right permissions
    - description : a message describing the action button to the user

This allows admins of databases to perform actions to fix problems on
their own or to fix their own customizations without external
intervention, it can also be used to provide support members a quick way
into the heart of a technical problem.

Task-ID: 1931559
Rationale:
With base_automation, users can trigger custom code on standard
workflows that will suit their specific needs (i.e. setting a field
after confirming a SO).  Sometimes, during these *simple* actions, an
error can occur due to various variables, such as a recent migration,
programming errors, module upgrades, etc., in such cases, it would be
great to drop the custom behavior temporarily to restore the standard
behavior, this would allow clients to keep doing business despite the
reduced features.

With this patch, if a base_automation triggers a crash, the crash
manager will propose (to users of the base_system group) the ability to
deactivate the infringing base_automation in order to continue their
workflow without the need to wait for external support.

Task-ID: 1931559
This kind of error is triggered whenever the display of a backend view
failed for whatever reason, additionally, this raising this error will
automatically allow the admin / support staff to go to the problematic
view's technical view and fix it / disable it.

Task-ID 1931559
@Elkasitu Elkasitu force-pushed the master-post-mortem-crash-manager-adt branch from 1c568ae to e55b3c8 Compare June 18, 2019 08:21
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jun 18, 2019
Copy link
Contributor

@bouvyd bouvyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't want to have this review request pending forever.

i have no opinion regarding this, i'll leave it to the framework team to handle it

bisous

@ryv-odoo ryv-odoo closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet