[FIX] mrp: wrong use of self #32923
Closed
[FIX] mrp: wrong use of self #32923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sle-odoo
reviewed
Apr 24, 2019
| @@ -827,3 +827,26 @@ def test_04b_test_planning_date(self): | |||
| # Check that the workorder is planned now and that it lasts one hour | |||
| self.assertEqual(workorder.date_planned_start, date_start, msg="Workorder should be planned tomorrow.") | |||
| self.assertEqual(workorder.date_planned_finished, date_start + timedelta(hours=1), msg="Workorder should be done one hour later.") | |||
|
|
|||
| def test_change_production_1(self): | |||
There was a problem hiding this comment.
test_change_production_quantity_1
""" Change the quantity to produce on the MO while workorders are already planned. """
The method _workorder_line_ids() is defined on mrp.workorder while `self` is an instance of change_production_qty wizard in this case. Without this commit, changing the quantity to produce of a manufactoring order with workorders already planned raised a traceback.
Whenrow
force-pushed
the
saas-12.3-fix-change-quantity-whe
branch
from
f1800f2
to
f6d8111
Compare
|
see #32948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method _workorder_line_ids() is defined on mrp.workorder while
selfis an instance of change_production_qty wizard in this case. Without this
commit, changing the quantity to produce of a manufactoring order with workorders
already planned raised a traceback.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr