Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account_asset: asset report shows only non archived assets #32955

Closed
wants to merge 1 commit into from

Conversation

kebeclibre
Copy link
Contributor

Make a PO then an invoice with a product that will create an asset
cancel the invoice
Open the Assets Analysis report

Before this commit, the asset lines corresponding to the invoice
are shown

After this commit, they are not shown (only non archived assets are)

OPW 1974344

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Copy link
Contributor

@william-andre william-andre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not better to add a filter in the asset analysis (by default)? That way we can still see the assets that are no longer active. You might want to see old assets in the analysis even though you don't use them anymore...

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 25, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 25, 2019
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 25, 2019
Make a PO then an invoice with a product that will create an asset
cancel the invoice
Open the Assets Analysis report

Before this commit, the asset lines corresponding to the invoice
are shown

After this commit, they are not shown (only non archived assets are by default)

OPW 1974344
@kebeclibre
Copy link
Contributor Author

@william-andre
Nice suggestion, changes made :D

@william-andre
Copy link
Contributor

Good for me

@kebeclibre
Copy link
Contributor Author

robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
robodoo pushed a commit that referenced this pull request Apr 25, 2019
Make a PO then an invoice with a product that will create an asset
cancel the invoice
Open the Assets Analysis report

Before this commit, the asset lines corresponding to the invoice
are shown

After this commit, they are not shown (only non archived assets are by default)

OPW 1974344

closes #32955

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
@robodoo robodoo added merging 👷 and removed r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
@robodoo
Copy link
Contributor

robodoo commented Apr 25, 2019

Staging failed: ci/runbot on fd08920176defe3c52998533a88d1e75829dd552 (view more at http://runbot.odoo.com/runbot/build/507603)

@kebeclibre
Copy link
Contributor Author

robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
@robodoo
Copy link
Contributor

robodoo commented Apr 25, 2019

Staging failed: ci/runbot on 2188296fb2a6fc851fb2881a80d51c7a0c225f00 (view more at http://runbot.odoo.com/runbot/build/507638)

@Xavier-Do
Copy link
Contributor

robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Apr 25, 2019
@robodoo
Copy link
Contributor

robodoo commented Apr 25, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 25, 2019
@fw-bot fw-bot deleted the 10.0-asset-report-active-lpe branch October 19, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants