Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] use ref instead of hardcoded ids #32960

Closed
wants to merge 1 commit into from
Closed

[12.0] use ref instead of hardcoded ids #32960

wants to merge 1 commit into from

Conversation

badbole
Copy link
Contributor

@badbole badbole commented Apr 25, 2019

Just for consistency reasons changed hardcoded ids in xml to ref

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019
@tde-banana-odoo tde-banana-odoo added the HR Related to Human Resources Applications label May 3, 2019
@RomainLibert
Copy link
Contributor

I'm ok with the change
However some the commit history is not clean (one empty merge commit, and I believe the CLA file is already present in 12.0)

@mart-e mart-e changed the base branch from 12.0 to master May 27, 2019 16:15
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 27, 2019
@mart-e
Copy link
Contributor

mart-e commented May 27, 2019

and it should target the master as this is a code cleaning and not a fix.
I have rebased on master and squashed commits.

@robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels May 27, 2019
robodoo pushed a commit that referenced this pull request May 27, 2019
@mart-e
[IMP] fleet: replace hardcoded ids by reference
6dde6b9 
More stable to changes

closes #32960

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented May 27, 2019

Merged, thanks!

@robodoo robodoo closed this May 27, 2019
@badbole badbole deleted the 12.0-fix-ids branch May 28, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses HR Related to Human Resources Applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@badbole @RomainLibert @mart-e @robodoo @tde-banana-odoo