[FIX] point-of-sale: discount line on ticket #32989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix an extra line with the price without discount will be printed even if there is no discount on the product. After this fix the line will only be printed if there is a discount. The error occured due to the use of t-else instead of t-elif.
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2019
Before this fix an extra line with the price without discount will be printed even if there is no discount on the product. After this fix the line will only be printed if there is a discount. The error occured due to the use of t-else instead of t-elif. closes #32989 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Due to the use of t-else instead of t-elif an extra line
will be printed on the ticket for every producteven if
not desired.
Current behavior before PR:
An extra line with the price without discount will be
printed even if there is no discount on the product.
Desired behavior after PR is merged:
The line will only be printed if there is a discount.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr