Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[various] Clean controlpanel actions #33720

Closed
wants to merge 18 commits into from
Closed

[various] Clean controlpanel actions #33720

wants to merge 18 commits into from

Conversation

hiralvbhavsar
Copy link
Contributor

@hiralvbhavsar hiralvbhavsar commented May 28, 2019 •
edited by tde-banana-odoo
Loading

PURPOSE

The 'action' dropdown on the controlpanel is starting to get messy. Their
labels are sometimes too long/repetitive. Some actions only make sense in
formview, some in listview, some in both. Some actions should be stat buttons.

Here are some of the 'guidelines' I've followed to clean those actions:
If the action already has a dedicated button in the formview, do not display
it in the formview action dropdown. Action labels always start with a verb.
Former actions that redirected to records are changed to stat buttons

SPECIFICATION

The following drive file defines all the changes to be done on actions:
https://docs.google.com/spreadsheets/d/1G0AtYs6VIXFz1vG32IoL457c_oy-OCXF9Tv19vLQdz8/edit?usp=sharing

The actions are grouped by object, which are grouped by product owner. The
ones in green are to be kept. The 'where' column specifies whether they should
be shown in formview, listview, or both. The ones in red are to be removed or
moved somewhere else (stat button, menu item). When an action is removed, check
whether the action it is calling is used somewhere else. If it is not the
case, remove it as well (clean the code).

Linked to task ID 1984526

@C3POdoo C3POdoo added the RD research & development, internal work label May 28, 2019
@hiralvbhavsar hiralvbhavsar force-pushed the master-clean-controlpanel-actions-hbh branch 3 times, most recently from 07cea07 to fc3aa32 Compare May 29, 2019 10:52
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label May 29, 2019
@fmdl
Copy link
Contributor

fmdl commented May 29, 2019

Idea 1 : in the tree list : show actions like a button, near the CREATE (add an option to show in the header or in the action dropdown menu)

@hiralvbhavsar hiralvbhavsar force-pushed the master-clean-controlpanel-actions-hbh branch from fc3aa32 to bdd56f7 Compare May 30, 2019 12:23
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 30, 2019
@hiralvbhavsar hiralvbhavsar force-pushed the master-clean-controlpanel-actions-hbh branch from bdd56f7 to f31e5ff Compare May 30, 2019 12:26
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] crm, website_crm_partner_assign: clean the controlpanel actions
701f26c 
For the model 'crm.lead'

- Rename the action menu 'Send an email' by 'Send email'.
- Remove the action menu 'Mark Late Activities as Done' and
  'Mark All Activities as Done'.
- Set 'Mark as lost' menu action only for the list view.
- Remove the action menu 'Assign salesman of assigned partner'.
- Rename the action menu 'Forward to Partner' by 'Forward to partner'
  and set it for both form and list view.

For the model 'res.partner', remove the actions menu 'Meetings'.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] (website_)sale: clean the controlpanel actions
9df284f 
For the model 'sale.order'

- Set the action menu 'Share' only for the form view of model.
- Rename the action menu 'Invoice Order' by 'Create invoices' and set
  only for the list view.
- Rename the action menu 'Send a Cart Recovery Email' by
  'Send cart recovery email' and set it only for the list view.
  Also improved tour 'shop_cart_recovery' as now action menu only
  available on the list view.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] point_of_sale: clean the controlpanel actions menu
c2bc4ee 
For the model 'pos.session'

- Remove the actions menu 'Put Money In', 'Take Money Out' and 'Orders'
  from the controlpanel actions menu.

For the model 'pos.config', remove 'Sessions' action menu.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] stock(_picking_batch): clean the controlpanel actions
1574861 
For the model 'stock.picking'
- Rename the action menu 'Assign a Responsible' by 'Assign responsible'
  and set it for the list view only.
- Rename the action menu 'Add to Batch' by 'Add to batch'

For the model 'stock.warehouse', remove the action menu 'Reordering Rules'

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] mrp(_account): clean the controlpanel action menu
9f3d3eb 
For model 'mrp.production', rename the action menu
'Mrp: Plan Production Orders' by 'Plan orders' and set it for the list
view only.

For the model 'product.template' and 'product.product', rename the menu
'Compute Price from BoM' by 'Compute cost from BoM' and set it for the
list view only.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] purchase: set the action menu 'Share' only for form view
2456f67 
For the model 'purchase.order', set the action menu 'Share' only for
the form view.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] repair: rename the action menu 'Create Invoice'
cba5847 
Rename the action menu 'Create Invoice' by 'Create invoices' for the
model 'repair.order'.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] hr_timesheet: remove the action menu 'Timesheet Entries'
32c01d1 
For the model 'project.task', remove the action menu 'Timesheet Entries'

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] hr_expense: clean the controlpanel action menu
5a2c328 
For the model 'hr.expense', rename the action menu 'Submit Report' by
'Submit report' and set it only for the list view.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] lunch: clean the controlpanel actions
6eef0ea 
- For the model 'lunch.order', rename the actions menu
  'Lunch: Receive meals' by 'Mark as received' and 'Lunch: Cancel meals'
  by 'Cancel'.
- For the model 'lunch.product', remove the action menu
  'Lunch: Archive/Restore products'

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] account(_*): clean the controlpanel actions
2b7d899 
* check_printing, voucher

For the model 'account.account',
- Replace the action menu 'Journal Items' by the stat button.
- Hide menu 'Journal Items for Tax Audit' from actions menu.

For the model 'account.invoice',
- Set action menu 'Share' only for the form view.
- Rename the action menu 'Confirm Draft Invoices' by 'Validate'.
- Rename 'Register Payment' by 'Register payment'.
- Rename 'Send' by 'Send & print'.

For the model 'account.move',
- Remove the menu 'Journal Items'.
- Rename 'Reverse Moves' by 'Reverse' and set it only for the list
  view.
- Rename 'Post Journal Entries' by 'Post entries' and set it only for
  the list view.

For the model 'account.move.line',r ename 'Reconcile Entries' by
'Reconcile' and 'Unreconcile Entries' by 'Unreconcile' and set it only
for the list view.

For the model 'account.payment',
- Rename 'Send Receipt By Email' by 'Send receipt by email' and set it
  for both form and list views.
- Rename 'Post Payments' by 'Confirm' and set it for the list view only
- Rename 'Print Checks' by 'Print checks' and set it for the list view
  only.

For the model 'account.journal', remove the menus 'Unpaid Invoices',
'Bank statements' and 'Voucher Entries'.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] hr(_*), website_hr: replace actions menu by stat button
b7c8cf1 
* attendance, contract, fleet, holidays, maintenance, presence,
  timesheet.

For the model 'hr.employee', replace the actions menu 'Archive/Restore'
by the stat button. That's why adapted changes regarding xpath.

Also rename the actions menu 'Time Off' by 'Time off'.

Linked to task 1984526
Related to PR #33720
robodoo pushed a commit that referenced this pull request Jul 11, 2019
@hbh-odoo @tde-banana-odoo
[IMP] product_margin: remove actions from the controlpanel action menu
d3abf5c 
Here remove the 'binding_model' attributes from 'act_window' to
remove the action menu 'Product Margins' from the 'product.product'
model

Linked to task 1984526
Related to PR #33720
@robodoo robodoo added error 🙅 and removed r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Jul 11, 2019
@robodoo
Copy link
Contributor

robodoo commented Jul 11, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/560741)

@tde-banana-odoo
Copy link
Contributor

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Jul 11, 2019
robodoo added a commit that referenced this pull request Jul 11, 2019
@robodoo
[various] Clean controlpanel actions
b4f45e1 
PURPOSE

The 'action' dropdown on the controlpanel is starting to get messy. Their
labels are sometimes too long/repetitive. Some actions only make sense in
formview, some in listview, some in both. Some actions should be stat buttons.

Here are some of the 'guidelines' I've followed to clean those actions:
If the action already has a dedicated button in the formview, do not display
it in the formview action dropdown. Action labels always start with a verb.
Former actions that redirected to records are changed to stat buttons

SPECIFICATION

The following drive file defines all the changes to be done on actions:
https://docs.google.com/spreadsheets/d/1G0AtYs6VIXFz1vG32IoL457c_oy-OCXF9Tv19vLQdz8/edit?usp=sharing

The actions are grouped by object, which are grouped by product owner. The
ones in green are to be kept. The 'where' column specifies whether they should
be shown in formview, listview, or both. The ones in red are to be removed or
moved somewhere else (stat button, menu item). When an action is removed, check
whether the action it is calling is used somewhere else. If it is not the
case, remove it as well (clean the code).

Linked to task ID 1984526

closes #33720

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo
Copy link
Contributor

robodoo commented Jul 11, 2019

Merged, thanks!

@robodoo robodoo closed this Jul 11, 2019
@tde-banana-odoo tde-banana-odoo deleted the master-clean-controlpanel-actions-hbh branch July 15, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hiralvbhavsar @fmdl @tde-banana-odoo @robodoo @C3POdoo @hbh-odoo