Use product website url and remove hardcoded image urls in website #34149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fja-odoo
changed the title
qsm-odoo
reviewed
Jun 25, 2019
fja-odoo
force-pushed
the
master-use-product-website-url-fja
branch
from
361257d
to
89bd2a8
Compare
robodoo
added
CI 🤖
fja-odoo
force-pushed
the
master-use-product-website-url-fja
branch
from
89bd2a8
to
85cfb90
Compare
robodoo
added
CI 🤖
rdeodoo
reviewed
Jul 22, 2019
rdeodoo
force-pushed
the
master-use-product-website-url-fja
branch
from
85cfb90
to
55802df
Compare
rdeodoo
force-pushed
the
master-use-product-website-url-fja
branch
from
55802df
to
5f51562
Compare
rdeodoo
reviewed
Jul 22, 2019
addons/website_slides/views/website_slides_templates_course.xml
Outdated
Show resolved
Hide resolved
addons/website_slides/views/website_slides_templates_course.xml
Outdated
Show resolved
Hide resolved
rdeodoo
force-pushed
the
master-use-product-website-url-fja
branch
from
5f51562
to
c4358d2
Compare
rdeodoo
reviewed
Jul 23, 2019
addons/website_sale_comparison/views/website_sale_comparison_template.xml
Outdated
Show resolved
Hide resolved
rdeodoo
force-pushed
the
master-use-product-website-url-fja
branch
from
c4358d2
to
26498ec
Compare
rdeodoo
force-pushed
the
master-use-product-website-url-fja
branch
from
26498ec
to
2c9a9bb
Compare
fja-odoo
force-pushed
the
master-use-product-website-url-fja
branch
from
2c9a9bb
to
caf9d15
Compare
robodoo
added
CI 🤖
qsm-odoo
requested changes
Aug 2, 2019
fja-odoo
force-pushed
the
master-use-product-website-url-fja
branch
from
caf9d15
to
a4cd2a5
Compare
robodoo
added
CI 🤖
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
@robodoo r- |
* = website_event_sale, website_sale_comparison, website_sale_wishlist Some product links were not using website_url, now that we have an url for product.product we should use that one to reach the right product. Part of odoo#34149 task-2007400
* = website_forum, website_profile, website_sale,
website_sale_comparison, website_slides, website_slides_survey
Some image links were hard coded in the xml views of website, now they
are replaced with website.image_url(model, field).
Part of odoo#34149
task-2007400
qsm-odoo
force-pushed
the
master-use-product-website-url-fja
branch
from
a4cd2a5
to
b495338
Compare
|
Linked pull request(s) odoo/enterprise#4587 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Aug 5, 2019
* = website_event_sale, website_sale_comparison, website_sale_wishlist Some product links were not using website_url, now that we have an url for product.product we should use that one to reach the right product. Part of #34149 task-2007400
robodoo
pushed a commit
that referenced
this pull request
Aug 5, 2019
* = website_forum, website_profile, website_sale, website_sale_comparison, website_slides, website_slides_survey Some image links were hard coded in the xml views of website, now they are replaced with website.image_url(model, field). Part of #34149 task-2007400 closes #34149 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
|
Merged at 5dac8f8, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some product links were not using website_url, now that we have an url
for product.product we should use that one to reach the right product.
Some image links were hard coded in the xml views of website, now they
are replaced with website.image_url(model, field).
Task: #2007400
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr