[IMP] mail, project: internal subtypes should be added based on pare… #34150

pka-odoo · 2019-06-14T13:22:10Z

…nt record

before this commit:

when user create task or ticket, the user won't be subscribed for the
internal subtypes, even if he followed it on project or helpdesk.
while changing the subtypes on the project, it does not affect on task for
subtypes which don't have parent_id

after this commit:

user will be created with followed internal subtypes based on parent record
when a user changes any subscription on the project then same will be applied
on task also for subtypes with parent_id, internal or default.

Task:
https://www.odoo.com/web#id=1974055&action=327&model=project.task&view_type=form&menu_id=4720

Pad:
https://pad.odoo.com/p/r.0178a74905bafcc0f74a81894e0059a9

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR odoo#47336 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of #34150 : * 16dd3da * 0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in 16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR #47336 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR odoo#47336 X-original-commit: odoo/odoo@9e7092a X-original-PR: odoo#47336 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of #34150 : * 16dd3da * 0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in 16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR #47336 X-original-commit: 9e7092a X-original-PR: #47336 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR odoo#47336 X-original-commit: 01254f0 X-original-pr: odoo#47336 Co-authored-by: Thibault Delavallee <tde@odoo.com> Co-authored-by: Alexandre Khun <aku@odoo.com> Co-authored-by: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of #34150 : * 16dd3da * 0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in 16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR #47336 X-original-commit: 01254f0 X-original-pr: #47336 Co-authored-by: Thibault Delavallee <tde@odoo.com> Co-authored-by: Alexandre Khun <aku@odoo.com> Co-authored-by: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@9e7092a This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 Task ID-2241688 COM PR odoo#56775 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR odoo#47336 X-original-commit: 01254f0 X-original-pr: odoo#47336 Co-authored-by: Thibault Delavallee <tde@odoo.com> Co-authored-by: Alexandre Khun <aku@odoo.com> Co-authored-by: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 9e7092a This commit contains a followup / rewrite / backport of #34150 : * 16dd3da * 0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in 16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 Task ID-2241688 COM PR #56775 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 odoo/odoo@9e7092a This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 Task ID-2241688 COM PR odoo#56775 X-Original-Commit odoo/odoo@b16117b Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

Manual backport of commit done in 13.0 9e7092a This commit contains a followup / rewrite / backport of #34150 : * 16dd3da * 0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in 16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 Task ID-2241688 COM PR #56775 X-Original-Commit b16117b Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

This commit contains a followup / rewrite / backport of odoo#34150 : * odoo/odoo@16dd3da * odoo/odoo@0b11ed8 Fix: propagate generic internal subtypes from parent to childs with auto subscribe. With this commit, when the user subscribes to internal subtypes like activities on a parent record (e.g. a project) then the user follows them by default on every sub record creation (e.g. all new tasks of this project). Fix: do not reset existing subtypes when changing parent of a record using auto subscribe mechanism. With this commit, when changing subtype subscription from a parent record (e.g. project) avoid resetting all subtypes subscription on existing sub records (e.g. all new tasks of this project). Only new records will use the parent chosen subtypes. This is done through propagation of followers existing policy (see Follower._insert_followers() for more details); Note that fix done here is slightly different from the one done in odoo/odoo@16dd3da as there was some mismatch with internal model-related subtypes. Thix fix will be forward ported and improve the previous one. Task ID-2205643 COM PR odoo#47336 X-original-commit: odoo/odoo@9e7092a X-original-PR: odoo#47336 Co-Authored-By: Thibault Delavallee <tde@odoo.com> Co-Authored-By: Alexandre Khun <aku@odoo.com> Co-Authored-By: Priyanka kakadiya <pka@odoo.com>

robodoo added the seen 🙂 label Jun 14, 2019

C3POdoo added the RD research & development, internal work label Jun 14, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch 2 times, most recently from dd58067 to bf72882 Compare June 17, 2019 08:59

robodoo added the CI 🤖 Robodoo has seen passing statuses label Jun 17, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from bf72882 to 8ace2e8 Compare June 19, 2019 13:19

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 19, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 8ace2e8 to 8d5fcad Compare June 20, 2019 06:18

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 20, 2019

mba-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 8d5fcad to 1d4647b Compare June 21, 2019 12:59

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 21, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 1d4647b to e3f3b10 Compare August 13, 2019 07:20

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Aug 13, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from e3f3b10 to 22add1a Compare August 13, 2019 08:46

robodoo added the CI 🤖 Robodoo has seen passing statuses label Aug 13, 2019

pka-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 22add1a to 6bbcade Compare August 14, 2019 06:48

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Aug 14, 2019

mba-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 6bbcade to 5bb0199 Compare September 2, 2019 05:06

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Sep 2, 2019

mba-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from 5bb0199 to e916e6f Compare October 17, 2019 05:39

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 17, 2019

mba-odoo force-pushed the master-mail-followers-activities-improvements-pka branch from e916e6f to 0a8221a Compare October 31, 2019 06:52

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 31, 2019

robodoo temporarily deployed to merge January 17, 2020 11:51 Inactive

alexkuhn deleted the master-mail-followers-activities-improvements-pka branch January 17, 2020 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] mail, project: internal subtypes should be added based on pare… #34150

[IMP] mail, project: internal subtypes should be added based on pare… #34150

pka-odoo commented Jun 14, 2019 •

edited

[IMP] mail, project: internal subtypes should be added based on pare… #34150

[IMP] mail, project: internal subtypes should be added based on pare… #34150

Conversation

pka-odoo commented Jun 14, 2019 • edited

pka-odoo commented Jun 14, 2019 •

edited