[IMP] account: install and load COA on company creation #34490

hdh-odoo · 2019-07-01T13:15:17Z

Description of the issue/feature this PR addresses:

Description

-previously COA were only being installed and loaded by themselves
when we were creating a new database.
-after this PR, this functionality will be available in
case of new company creation as well.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

jco-odoo

Can you check this comments and also backport to 12.5?

jco-odoo · 2019-09-12T10:31:44Z

addons/account/models/company.py

+                        module_ids.with_context({'allowed_company_ids': [company.id]}).button_immediate_install()
+                    #localizaton for the given country is already installed.
+                    else:
+                        #filter out the list of templates that belong to newly created company's country and load the first one.


I don't think this is needed as it is the localization itself that decides whether it already installs the CoA or not. Leave out the else part. And why button_install in the first and button_immediate_install in the second?

I didn't get you. This code is there to load appropriate templates for the new company. If we remove this, templates won't be loaded for new company even when they are installed.
kindly let me know If I misunderstood something. Thanks.

@hdh-odoo In most localizations, there is a script that loads it automatically for the current company. (try_loading...)

@jva-odoo The logic should be different: 1 check if the module has been installed or not: if not, install / if already there: create a method to install the chart of accounts that localizations can inherit. (with more or less in it what is below)

@jco-odoo here 1 we check module is installed or not using "module_ids": after if not installed then we install using button_immediate_install else installed then we call try_loading_for_current_company.
Logic is the same as you say....so I didn't get where this is wrong or need improvement...!!?

from_init or not, it should check if the module is installed or not. And actually installing the CoA could be the same thing. So, why do we need from_init in the first place?

@jco-odoo from company create method if I call button_install then it's not installing a module so I need to call button_immediate_install instead of button_install.

The button_immediate_install is needed (put it in a comment) for blocking concurrent access with the crons that might be running.

jco-odoo · 2019-09-12T10:32:25Z

addons/account/models/company.py

+    def create(self, vals):
+        company = super(ResCompany, self).create(vals)
+        company._install_localization_packages()
+        return company


We should also do this on the write when the country_id was False before?

I will make the appropriate changes. Thanks.

jco-odoo

Can this still be adapted?

jco-odoo · 2019-10-15T14:59:20Z

addons/account/models/company.py

+                    if country_code in europe_country_codes:
+                        module_list.append('account_sepa')
+                        module_list.append('account_bank_statement_import_camt')
+                module_ids = company.env['ir.module.module'].search([('name', 'in', module_list), ('state', '=', 'uninstalled')])


should be self.env

jco-odoo · 2019-10-15T15:14:18Z

addons/account/__init__.py

-                module_list.append('account_bank_statement_import_camt')
-        module_ids = env['ir.module.module'].search([('name', 'in', module_list), ('state', '=', 'uninstalled')])
-        module_ids.sudo().button_install()
+    env.company._install_localization_packages(from_init = True)


from_init=True

jco-odoo · 2019-10-15T15:19:04Z

addons/account/models/company.py

@@ -278,6 +280,73 @@ def _validate_fiscalyear_lock(self, values):
            if nb_draft_entries:
                raise ValidationError(_('There are still unposted entries in the period you want to lock. You should either post or delete them.'))

+    def _install_localization_packages(self, from_init=False):
+        for company in self:


Do not do the for-loop. We are only going to install one company at a time. Better to use ensure_one

@jco-odoo because we also call from write so I think it's good to do in for loop

ok, I put for loop in write method. 👍

jco-odoo · 2019-10-15T15:25:35Z

addons/account/models/company.py

+                    #a new company is being created.
+                    #localization for the given country isn't installed.
+                    if module_ids:
+                        module_ids.with_context({'allowed_company_ids': [company.id]}).button_immediate_install()


Better to use sudo() and you only need to set company_id (check how it is done elsewhere)

jco-odoo · 2019-10-15T15:25:41Z

addons/account/models/company.py

+                        module_ids.with_context({'allowed_company_ids': [company.id]}).button_immediate_install()
+                    #localizaton for the given country is already installed.
+                    else:
+                        #filter out the list of templates that belong to newly created company's country and load the first one.


The button_immediate_install is needed (put it in a comment) for blocking concurrent access with the crons that might be running.

jco-odoo · 2019-10-15T15:26:38Z

addons/account/models/company.py

+                        chart_template_xml_ids = self.env['ir.model.data'].search([('module', 'in', module_list), ('model', '=', 'account.chart.template')])
+                        if chart_template_xml_ids:
+                            chart_template = self.env['account.chart.template'].browse(chart_template_xml_ids[0].res_id)
+                            chart_template.with_context({'allowed_company_ids': [company.id]}).try_loading_for_current_company()


same comment + try_loading_for_current_company is deprecated. (just try_loading)

jco-odoo · 2019-10-15T15:26:51Z

addons/account/models/company.py

+    def create(self, vals):
+        company = super(ResCompany, self).create(vals)
+        company._install_localization_packages()
+        return company


jva-odoo · 2019-10-16T08:52:50Z

@jco-odoo change done 👍

jco-odoo · 2019-10-16T09:12:53Z

@jva-odoo Do you rebase with last master and check if it is green?

jva-odoo · 2019-10-16T09:16:02Z

ok 👍

jco-odoo · 2019-10-16T11:23:16Z

addons/account/models/company.py

    def write(self, values):
        #restrict the closing of FY if there are still unposted entries
        self._validate_fiscalyear_lock(values)
-
+        company_without_coa = self.filtered(lambda c: not c.chart_template_id)


Better to use "existing accounting" method, but better to check it only when not self.country_id and values.get('country_id') I don't think you check not self.country_id here

pedrobaeza · 2019-10-23T11:52:13Z

Can this be closed?

jco-odoo · 2019-10-23T12:31:16Z

@pedrobaeza Why? We are working on it.

pedrobaeza · 2019-10-23T12:33:51Z

It appears to me in codetriage.com, and seeing the age, I thought it was stalled.

jco-odoo · 2019-10-23T12:40:35Z

@jva-odoo Is this the latest one? Because I made comments here, but I don't see any adaptations.

Now, on creating company, appropriate localization module will be installed and loaded based on the country selected for that company. If, user did not set country while creating company then whenever user sets country for that company, appropriate CoA will be loaded. The functionality is disabled when company created from running test cases as module installation are forbidden from test cases. l10n_ar: Since there are multiple CoA for Argentina country and appropriate CoA for particular company can only be determined when user sets AFIP Responsibility field, this thing has been managed also. Task: 2027057 Closes: odoo#34490 Related: odoo/enterprise#8189

Company card should always have Time Off project and task configured. The same is managed through overriding BaseModel's init(). In scenario where localization module automatically installs itself at the time of company creation if country selected for it, application throws missing attribute exception. Below is the link describing the traceback: https://pastebin.com/cAzSEA1g Steps to reproduce traceback are as follows: 1. Install account module. 2. Install project_timesheet_holidays 3. Attempt to create a new company with country Singapore set. Similar tracebacks observed for German, and Mexican localizations.

robodoo added the seen 🙂 label Jul 1, 2019

hdh-odoo force-pushed the master-account-auto-install-localization branch from 14cb041 to 67d73ab Compare July 1, 2019 13:48

C3POdoo added the RD research & development, internal work label Jul 1, 2019

robodoo added the CI 🤖 Robodoo has seen passing statuses label Jul 1, 2019

hdh-odoo force-pushed the master-account-auto-install-localization branch from 67d73ab to 2886a21 Compare July 2, 2019 05:05

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jul 2, 2019

hdh-odoo force-pushed the master-account-auto-install-localization branch from 2886a21 to cec4a58 Compare July 2, 2019 09:11

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jul 2, 2019

hdh-odoo force-pushed the master-account-auto-install-localization branch from cec4a58 to b64ca0d Compare July 3, 2019 09:13

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jul 3, 2019

hdh-odoo force-pushed the master-account-auto-install-localization branch from b64ca0d to c860e88 Compare August 28, 2019 10:18

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Aug 28, 2019

jco-odoo requested changes Sep 12, 2019

View reviewed changes

jco-odoo requested changes Oct 15, 2019

View reviewed changes

jva-odoo force-pushed the master-account-auto-install-localization branch from c860e88 to 2db9894 Compare October 16, 2019 08:45

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Oct 16, 2019

jva-odoo force-pushed the master-account-auto-install-localization branch from 2db9894 to 6f95916 Compare October 16, 2019 10:28

jco-odoo reviewed Oct 16, 2019

View reviewed changes

jva-odoo force-pushed the master-account-auto-install-localization branch from 6f95916 to 1208b80 Compare October 30, 2019 09:36

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 5, 2020

rgo-odoo force-pushed the master-account-auto-install-localization branch from 61feb7e to 074758c Compare May 7, 2020 13:20

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 7, 2020

qsb-odoo force-pushed the master-account-auto-install-localization branch from 074758c to dfe89de Compare May 14, 2020 13:23

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 14, 2020

qsb-odoo force-pushed the master-account-auto-install-localization branch from dfe89de to 48332ba Compare May 15, 2020 05:57

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 15, 2020

rgo-odoo force-pushed the master-account-auto-install-localization branch from 48332ba to 430d5d5 Compare May 20, 2020 07:01

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 20, 2020

qsb-odoo force-pushed the master-account-auto-install-localization branch from 430d5d5 to a7cc611 Compare May 20, 2020 08:54

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 20, 2020

robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 22, 2020

qsb-odoo added 2 commits May 25, 2020 09:11

qsb-odoo force-pushed the master-account-auto-install-localization branch from 0ce4011 to a39c59a Compare May 25, 2020 03:49

robodoo added the CI 🤖 Robodoo has seen passing statuses label May 25, 2020

xmo-odoo removed the seen 🙂 label Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] account: install and load COA on company creation #34490

[IMP] account: install and load COA on company creation #34490

hdh-odoo commented Jul 1, 2019

jco-odoo left a comment

jco-odoo Sep 12, 2019

hdh-odoo Sep 17, 2019

jco-odoo Sep 24, 2019

jco-odoo Oct 14, 2019

jva-odoo Oct 14, 2019

jco-odoo Oct 14, 2019

jva-odoo Oct 15, 2019

jco-odoo Oct 15, 2019

jco-odoo Sep 12, 2019

hdh-odoo Sep 17, 2019

jco-odoo Oct 15, 2019

jco-odoo left a comment

jco-odoo Oct 15, 2019

jco-odoo Oct 15, 2019

jco-odoo Oct 15, 2019

jva-odoo Oct 16, 2019

jva-odoo Oct 16, 2019

jco-odoo Oct 15, 2019

jva-odoo Oct 16, 2019

jco-odoo Oct 15, 2019

jco-odoo Oct 15, 2019

jva-odoo Oct 16, 2019

jco-odoo Oct 15, 2019

jva-odoo commented Oct 16, 2019

jco-odoo commented Oct 16, 2019

jva-odoo commented Oct 16, 2019

jco-odoo Oct 16, 2019

jco-odoo Oct 16, 2019

pedrobaeza commented Oct 23, 2019

jco-odoo commented Oct 23, 2019

pedrobaeza commented Oct 23, 2019

jco-odoo commented Oct 23, 2019

[IMP] account: install and load COA on company creation #34490

Are you sure you want to change the base?

[IMP] account: install and load COA on company creation #34490

Conversation

hdh-odoo commented Jul 1, 2019

jco-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jco-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jva-odoo commented Oct 16, 2019

jco-odoo commented Oct 16, 2019

jva-odoo commented Oct 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 23, 2019

jco-odoo commented Oct 23, 2019

pedrobaeza commented Oct 23, 2019

jco-odoo commented Oct 23, 2019