Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] purchase: add section and notes lines #34737

Closed

Conversation

Feyensv
Copy link
Contributor

@Feyensv Feyensv commented Jul 10, 2019

For the future matrix, to be able to share logic between sale and purchase, the section and note widget is added to purchase as well.

Section and Notes available on Purchase Order Lines

Those display lines are applied to reports but NOT to invoices (account.move).

@C3POdoo C3POdoo added the RD research & development, internal work label Jul 10, 2019
@Feyensv Feyensv force-pushed the master-purchase-section-and-note-vfe branch from eafdc2f to 80dfcc6 Compare July 10, 2019 10:11
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jul 10, 2019
@Feyensv Feyensv requested a review from bouvyd July 10, 2019 11:19
Copy link
Contributor

@bouvyd bouvyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addons/purchase/models/purchase.py Outdated Show resolved Hide resolved
addons/purchase/models/purchase.py Outdated Show resolved Hide resolved
addons/purchase/models/purchase.py Outdated Show resolved Hide resolved
addons/purchase/models/purchase.py Show resolved Hide resolved
addons/purchase/views/portal_templates.xml Show resolved Hide resolved
addons/purchase/views/purchase_views.xml Outdated Show resolved Hide resolved
@Feyensv Feyensv force-pushed the master-purchase-section-and-note-vfe branch from 80dfcc6 to 9d20482 Compare July 12, 2019 09:54
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jul 12, 2019
@Feyensv Feyensv force-pushed the master-purchase-section-and-note-vfe branch from 9d20482 to b1c26fe Compare July 12, 2019 11:39
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jul 12, 2019
Ravi Gadhia and others added 2 commits July 16, 2019 10:18
@Feyensv Feyensv force-pushed the master-purchase-section-and-note-vfe branch from b1c26fe to 392ced7 Compare July 16, 2019 08:38
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jul 16, 2019
@bouvyd
Copy link
Contributor

bouvyd commented Jul 16, 2019

LGTM 📯
@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Jul 16, 2019

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Jul 16, 2019
> support kanban view for order lines in puchase form view.

closes #34737

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Jul 16, 2019

Merged, thanks!

@robodoo robodoo closed this Jul 16, 2019
@bouvyd bouvyd deleted the master-purchase-section-and-note-vfe branch July 16, 2019 11:48
Feyensv added a commit to odoo-dev/odoo that referenced this pull request Oct 11, 2019
odoo#34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.
robodoo pushed a commit that referenced this pull request Oct 28, 2019
#34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.

closes #38232

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Oct 28, 2019
odoo#34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.

X-original-commit: 1e8ea4f
robodoo pushed a commit that referenced this pull request Oct 28, 2019
#34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.

closes #39474

X-original-commit: 1e8ea4f
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
agyamuta added a commit to adriansteel/odoo that referenced this pull request Mar 28, 2023
… used

odoo@abf2322#diff-86168e4c37e9a7c1437998990c2aa4e1690d16605812f57a81172936377b9c50R363

Summary from the PR:
For the future matrix, to be able to share logic between sale and purchase, the section and note widget is added to purchase as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants