[IMP] product: barcode should not disappear in template when archiving a product #34769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchoksi-github
changed the title
parthchoksi-github
force-pushed
the
master-product-make-barcode-compute-pch
branch
2 times, most recently
from
4de39fd
to
28f00a2
Compare
parthchoksi-github
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
28f00a2
to
0d2fd51
Compare
parthchoksi-github
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
0d2fd51
to
65b1a58
Compare
|
Oh, this was not merged in v13 :( cc: @nim-odoo |
Whenrow
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
65b1a58
to
1437996
Compare
robodoo
added
CI 🤖
Whenrow
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
1437996
to
820e17a
Compare
robodoo
added
CI 🤖
Whenrow
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
820e17a
to
8b1e4a0
Compare
Whenrow
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
8b1e4a0
to
6df44ed
Compare
Whenrow
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
6df44ed
to
67f8c17
Compare
robodoo
added
CI 🤖
Before this commit when a user archives the product, the barcode field in its template used to get disappeared. Since barcode field in template is a related field to product, the field gets invisible in product template when the user archives the related product. After this commit, even when a product is archived, its barcode will still be visible in template. Here the barcode field is changed from related to computed. task-1978559
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants
sle-odoo
force-pushed
the
master-product-make-barcode-compute-pch
branch
from
67f8c17
to
ee6ddfc
Compare
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
robodoo
pushed a commit
that referenced
this pull request
Mar 10, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants closes #34769 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
nle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-12.3 backport of odoo#34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes odoo#49906
nle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-13.2 backport of odoo#34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes odoo#49888
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-12.3 backport of #34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes #49906 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-13.2 backport of #34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes #49888 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-13.2 backport of odoo#34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes odoo#49888 X-original-commit: b83da36
nle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-12.3 backport of odoo#34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes odoo#49906 X-original-commit: c2f86f6
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-12.3 backport of #34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes #49906 closes #49929 X-original-commit: c2f86f6 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
immontilla
pushed a commit
to immontilla/odoo
that referenced
this pull request
Apr 26, 2020
Steps to reproduce: * Create a template with 2 variants * Archive one variant * Unarchive this same variant --> the template is archived This is due to commit 6a13b56. If the variant is the only one, toggle_active on the variant should be reflected on the template. The issue is that toggle active do not count archived variant. One active variant and one archived variant are counted as 1. This commit make toggle_active count all variants saas-12.3 backport of odoo#34769 note: saas-13.3 commit f36d0ce backported because the issue was solved differently in 13.0 a266ff5 but it's better to have the same code accross all version. opw-2226294 closes odoo#49906 closes odoo#49929 X-original-commit: c2f86f6 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barcode field disappears in template(product.template) when you archive the same record from product('product.product')'
Here we are making sure that even when a product is archived, its barcode is still visible in template.
We had to change barcode from a related field to a computed field.
Task- https://www.odoo.com/web#id=1978559&action=333&active_id=966&model=project.task&view_type=form&menu_id=4720
Pad- https://pad.odoo.com/p/r.1118e013e6c395157a91b17029dcea74
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr