[FIX] bank statement reconciliation by ref

[yvaucher]

Since invoice_payment_ref exists on account.move it should be the reference
used for reconciliation. For instance for structured refs like l10n_be_invoice_bba or ISR in l10n_ch

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[yvaucher]

@qdp-odoo @jcr-odoo In my opinion ref is to be replaced by invoice_payment_ref in the tests accordingly, or do you think we should make the search on 3 fields instead of 2.
(name, invoice_payment_ref, ref)

Because the structured ref will go into invoice_payment_ref, thus it should be the first field we search into.

As I understand ref is a supplier reference only used on vendor bills while invoice_payment_ref is present on both vendor bills and customer's invoices.
Thus, for bank statement reconcile we must use invoice_payment_ref. Do you see a case when we need to use ref in reconciliation?

[yvaucher]

message copied from #34476 on why I created this PR

I couldn't make the automatic reconciliation work from the invoice_payment_ref.

I created an invoice
I validated the invoice which copy the ISR in invoice_reference_payment but with a hack [1]

Then I created a bank statement and I tried to reconcile it.

No match were found:

I tried to put the ISR reference in Label and in Reference fields, with or without spaces (all 4 combinations), no match.

[1] I commented line

odoo/addons/account/models/account_move.py

Line 798 in 2e640a3

self.invoice_payment_ref = new_terms_lines[-1].name or ''

to pass condition at

odoo/addons/account/models/account_move.py

Line 1887 in 3fdb6b6

if move.type == 'out_invoice' and not move.invoice_payment_ref:

[yvaucher]

@william-andre @jco-odoo I added a fixup to try not to break supplier invoice reconciliation that uses ref

@william-andre is it what you had in mind?

[william-andre]

@yvaucher Something like that but you have a syntax error because you declare twice communication_flag in the SELECT

[smetl]

will be fixed by #36062