[FIX] stock: remove move 'without package' properly #36241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmdl
reviewed
Sep 1, 2019
|
|
||
| def _set_move_without_package(self): | ||
| self.move_lines |= self.move_ids_without_package | ||
| new_mwp = self[0].move_ids_without_package |
There was a problem hiding this comment.
this is strange : self[0] then for picking in self
def _set_move_without_package(self):
self.move_lines = self.move_lines | self._get_move_ids_without_package()
on a picking, move_ids_without_package is a subset of move_lines. The inverse function on move_ids_without_package only work well when we add a move. This commit improves the inverse function to take deletion into account
Whenrow
force-pushed
the
saas-12.5-delete-move-whe
branch
from
514156d
to
179db08
Compare
|
see #36558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a picking, move_ids_without_package is a subset of move_lines.
The inverse function on move_ids_without_package only work well when we
add a move.
This commit improves the inverse function to take deletion into account
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr