[IMP] Use locale week-start in datepicker #36532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-pelykh
force-pushed
the
use-week_start-in-datepicker
branch
from
2f7f0cc
to
5bc472b
Compare
alexey-pelykh
force-pushed
the
use-week_start-in-datepicker
branch
from
5bc472b
to
76dea04
Compare
alexey-pelykh
force-pushed
the
use-week_start-in-datepicker
branch
2 times, most recently
from
c080bdc
to
7bd1e59
Compare
alexey-pelykh
force-pushed
the
use-week_start-in-datepicker
branch
from
7bd1e59
to
9bed48d
Compare
alexey-pelykh
force-pushed
the
use-week_start-in-datepicker
branch
from
9bed48d
to
c5a14c0
Compare
|
@andriisem @naglis @KAMLESHAHIR @xabispacebiker I believe this PR would be of interest for you. @Yenthe666 this one is related to #30709 as well |
andriisem
approved these changes
Sep 10, 2019
|
@mart-e @RomainLibert where should this go? |
|
@alexey-pelykh This should probably be reviewed by the js framework |
aab-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Oct 10, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes odoo#36450 Closes odoo#36532
robodoo
pushed a commit
that referenced
this pull request
Oct 10, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes #36450 Closes #36532 closes #38344 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Oct 11, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes odoo#36450 Closes odoo#36532
fw-bot
added a commit
to odoo-dev/odoo
that referenced
this pull request
Oct 11, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes odoo#36450 Closes odoo#36532 X-original-commit: eeb5183
robodoo
pushed a commit
that referenced
this pull request
Oct 11, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes #36450 Closes #36532 closes #38472 X-original-commit: eeb5183 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Oct 11, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes #36450 Closes #36532 closes #38472 X-original-commit: eeb5183 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Oct 11, 2019
Before this rev., if the week_start param (the first day of week) of the user language was changed, it wasn't reflected on datepickers (however, it worked fine in the calendar view). This rev. makes this work by updating the moment locale with the corresponding param. Fixes #36450 Closes #36532 closes #38472 X-original-commit: eeb5183 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
3 tasks
Tonow-c2c
added a commit
to Tonow-c2c/server-ux
that referenced
this pull request
May 19, 2020
Tonow-c2c
added a commit
to Tonow-c2c/server-ux
that referenced
this pull request
May 19, 2020
Tonow-c2c
added a commit
to Tonow-c2c/server-ux
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses: #36450
Current behavior before PR:
Change of locale's week-start does not affect datepicker.
Desired behavior after PR is merged:
Change of locale's week-start affects datepicker.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr