[FIX] product: price list reports with too many fractional digits #36705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim-odoo
requested changes
Sep 11, 2019
Before this commit, when printing the Price List report of a Product Variant, the price is printed directly from the float result of the calculation of the price, even if this price is rounded, the representation of the float can have, sometimes, float precision errors (a lot of 0 after the decimal point, and a 1 or 2 at the end). Now, the function returns a string formatted to the correct number of fractional digits. opw-2069305
jpp-odoo
force-pushed
the
12.0-opw-2069305-float_pricelist_printing-jpp
branch
from
2e9421e
to
6403767
Compare
|
@nim-odoo I just made the changes we talk about. |
|
Merged at 4ae4c55, thanks! |
nim-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 12, 2019
Before this commit, when printing the Price List report of a Product Variant, the price is printed directly from the float result of the calculation of the price, even if this price is rounded, the representation of the float can have, sometimes, float precision errors (a lot of 0 after the decimal point, and a 1 or 2 at the end). Now, the function returns a string formatted to the correct number of fractional digits. opw-2069305 closes odoo#36705 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 12, 2019
Before this commit, when printing the Price List report of a Product Variant, the price is printed directly from the float result of the calculation of the price, even if this price is rounded, the representation of the float can have, sometimes, float precision errors (a lot of 0 after the decimal point, and a 1 or 2 at the end). Now, the function returns a string formatted to the correct number of fractional digits. opw-2069305 closes #36705 closes #36770 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
@jpp-odoo maybe to backport in v11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when printing the Price List report of a Product
Variant, the price is printed directly from the float result of the
calculation of the price, even if this price is rounded, the
representation of the float can have, sometimes, float precision errors
(a lot of 0 after the decimal point, and a 1 or 2 at the end).
Now, the function returns a string formatted to the correct number of
fractional digits.
opw-2069305