Forward Port of #36733 to 12.0 (fixed) #36736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @nim-odoo |
|
@xmo-odoo this one also faced the issue |
- Activate variants - On a product variant without BOM, go to Action > Compute Price from BOM A zero-division is raised because of `... / bom.product_qty`. opw-2067520 closes odoo#36733 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
nim-odoo
force-pushed
the
12.0-saas-11.3-opw-2067520-bom_cost-nim-ZVT2FO2M-forwardport
branch
from
c9fc841
to
87608cd
Compare
nim-odoo
changed the title
|
robodoo r+ |
|
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/616501) |
robodoo
added
error 🙅
and removed
CI 🤖
|
robodoo retry |
|
Merged at e17c562, thanks! |
nim-odoo
deleted the
12.0-saas-11.3-opw-2067520-bom_cost-nim-ZVT2FO2M-forwardport
branch
nim-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 12, 2019
- Activate variants - On a product variant without BOM, go to Action > Compute Price from BOM A zero-division is raised because of `... / bom.product_qty`. opw-2067520 closes odoo#36733 closes odoo#36736 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 12, 2019
- Activate variants - On a product variant without BOM, go to Action > Compute Price from BOM A zero-division is raised because of `... / bom.product_qty`. opw-2067520 closes #36733 closes #36736 closes #36749 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicking 08d9b45 of source #36733 failed with the following
stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding
as usual) or close this PR (maybe?).
In the former case, you may want to edit this PR message as well.